2018-08-24 23:40:41 +00:00
|
|
|
package csv
|
|
|
|
|
|
|
|
import (
|
|
|
|
"fmt"
|
|
|
|
"testing"
|
|
|
|
"time"
|
|
|
|
|
2019-05-14 18:29:44 +00:00
|
|
|
"github.com/influxdata/telegraf"
|
2018-08-24 23:40:41 +00:00
|
|
|
"github.com/influxdata/telegraf/metric"
|
2018-09-18 16:23:45 +00:00
|
|
|
"github.com/influxdata/telegraf/testutil"
|
2018-08-24 23:40:41 +00:00
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
)
|
|
|
|
|
2018-09-18 16:23:45 +00:00
|
|
|
var DefaultTime = func() time.Time {
|
|
|
|
return time.Unix(3600, 0)
|
|
|
|
}
|
|
|
|
|
2018-08-24 23:40:41 +00:00
|
|
|
func TestBasicCSV(t *testing.T) {
|
|
|
|
p := Parser{
|
|
|
|
ColumnNames: []string{"first", "second", "third"},
|
|
|
|
TagColumns: []string{"third"},
|
2018-09-18 16:23:45 +00:00
|
|
|
TimeFunc: DefaultTime,
|
2018-08-24 23:40:41 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
_, err := p.ParseLine("1.4,true,hi")
|
|
|
|
require.NoError(t, err)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestHeaderConcatenationCSV(t *testing.T) {
|
|
|
|
p := Parser{
|
|
|
|
HeaderRowCount: 2,
|
|
|
|
MeasurementColumn: "3",
|
2018-09-18 16:23:45 +00:00
|
|
|
TimeFunc: DefaultTime,
|
2018-08-24 23:40:41 +00:00
|
|
|
}
|
|
|
|
testCSV := `first,second
|
|
|
|
1,2,3
|
|
|
|
3.4,70,test_name`
|
|
|
|
|
|
|
|
metrics, err := p.Parse([]byte(testCSV))
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, "test_name", metrics[0].Name())
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestHeaderOverride(t *testing.T) {
|
|
|
|
p := Parser{
|
|
|
|
HeaderRowCount: 1,
|
|
|
|
ColumnNames: []string{"first", "second", "third"},
|
|
|
|
MeasurementColumn: "third",
|
2018-09-18 16:23:45 +00:00
|
|
|
TimeFunc: DefaultTime,
|
2018-08-24 23:40:41 +00:00
|
|
|
}
|
|
|
|
testCSV := `line1,line2,line3
|
|
|
|
3.4,70,test_name`
|
|
|
|
metrics, err := p.Parse([]byte(testCSV))
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, "test_name", metrics[0].Name())
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestTimestamp(t *testing.T) {
|
|
|
|
p := Parser{
|
|
|
|
HeaderRowCount: 1,
|
|
|
|
ColumnNames: []string{"first", "second", "third"},
|
|
|
|
MeasurementColumn: "third",
|
|
|
|
TimestampColumn: "first",
|
|
|
|
TimestampFormat: "02/01/06 03:04:05 PM",
|
2018-09-18 16:23:45 +00:00
|
|
|
TimeFunc: DefaultTime,
|
2018-08-24 23:40:41 +00:00
|
|
|
}
|
|
|
|
testCSV := `line1,line2,line3
|
|
|
|
23/05/09 04:05:06 PM,70,test_name
|
|
|
|
07/11/09 04:05:06 PM,80,test_name2`
|
|
|
|
metrics, err := p.Parse([]byte(testCSV))
|
|
|
|
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, metrics[0].Time().UnixNano(), int64(1243094706000000000))
|
|
|
|
require.Equal(t, metrics[1].Time().UnixNano(), int64(1257609906000000000))
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestTimestampError(t *testing.T) {
|
|
|
|
p := Parser{
|
|
|
|
HeaderRowCount: 1,
|
|
|
|
ColumnNames: []string{"first", "second", "third"},
|
|
|
|
MeasurementColumn: "third",
|
|
|
|
TimestampColumn: "first",
|
2018-09-18 16:23:45 +00:00
|
|
|
TimeFunc: DefaultTime,
|
2018-08-24 23:40:41 +00:00
|
|
|
}
|
|
|
|
testCSV := `line1,line2,line3
|
|
|
|
23/05/09 04:05:06 PM,70,test_name
|
|
|
|
07/11/09 04:05:06 PM,80,test_name2`
|
|
|
|
_, err := p.Parse([]byte(testCSV))
|
|
|
|
require.Equal(t, fmt.Errorf("timestamp format must be specified"), err)
|
|
|
|
}
|
|
|
|
|
2018-11-29 00:07:25 +00:00
|
|
|
func TestTimestampUnixFormat(t *testing.T) {
|
|
|
|
p := Parser{
|
|
|
|
HeaderRowCount: 1,
|
|
|
|
ColumnNames: []string{"first", "second", "third"},
|
|
|
|
MeasurementColumn: "third",
|
|
|
|
TimestampColumn: "first",
|
|
|
|
TimestampFormat: "unix",
|
|
|
|
TimeFunc: DefaultTime,
|
|
|
|
}
|
|
|
|
testCSV := `line1,line2,line3
|
|
|
|
1243094706,70,test_name
|
|
|
|
1257609906,80,test_name2`
|
|
|
|
metrics, err := p.Parse([]byte(testCSV))
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, metrics[0].Time().UnixNano(), int64(1243094706000000000))
|
|
|
|
require.Equal(t, metrics[1].Time().UnixNano(), int64(1257609906000000000))
|
|
|
|
}
|
|
|
|
|
2018-11-29 00:19:53 +00:00
|
|
|
func TestTimestampUnixMSFormat(t *testing.T) {
|
|
|
|
p := Parser{
|
|
|
|
HeaderRowCount: 1,
|
|
|
|
ColumnNames: []string{"first", "second", "third"},
|
|
|
|
MeasurementColumn: "third",
|
|
|
|
TimestampColumn: "first",
|
|
|
|
TimestampFormat: "unix_ms",
|
|
|
|
TimeFunc: DefaultTime,
|
|
|
|
}
|
|
|
|
testCSV := `line1,line2,line3
|
|
|
|
1243094706123,70,test_name
|
|
|
|
1257609906123,80,test_name2`
|
|
|
|
metrics, err := p.Parse([]byte(testCSV))
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, metrics[0].Time().UnixNano(), int64(1243094706123000000))
|
|
|
|
require.Equal(t, metrics[1].Time().UnixNano(), int64(1257609906123000000))
|
|
|
|
}
|
|
|
|
|
2018-08-24 23:40:41 +00:00
|
|
|
func TestQuotedCharacter(t *testing.T) {
|
|
|
|
p := Parser{
|
|
|
|
HeaderRowCount: 1,
|
|
|
|
ColumnNames: []string{"first", "second", "third"},
|
|
|
|
MeasurementColumn: "third",
|
2018-09-18 16:23:45 +00:00
|
|
|
TimeFunc: DefaultTime,
|
2018-08-24 23:40:41 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
testCSV := `line1,line2,line3
|
|
|
|
"3,4",70,test_name`
|
|
|
|
metrics, err := p.Parse([]byte(testCSV))
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, "3,4", metrics[0].Fields()["first"])
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestDelimiter(t *testing.T) {
|
|
|
|
p := Parser{
|
|
|
|
HeaderRowCount: 1,
|
|
|
|
Delimiter: "%",
|
|
|
|
ColumnNames: []string{"first", "second", "third"},
|
|
|
|
MeasurementColumn: "third",
|
2018-09-18 16:23:45 +00:00
|
|
|
TimeFunc: DefaultTime,
|
2018-08-24 23:40:41 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
testCSV := `line1%line2%line3
|
|
|
|
3,4%70%test_name`
|
|
|
|
metrics, err := p.Parse([]byte(testCSV))
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, "3,4", metrics[0].Fields()["first"])
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestValueConversion(t *testing.T) {
|
|
|
|
p := Parser{
|
|
|
|
HeaderRowCount: 0,
|
|
|
|
Delimiter: ",",
|
|
|
|
ColumnNames: []string{"first", "second", "third", "fourth"},
|
|
|
|
MetricName: "test_value",
|
2018-09-18 16:23:45 +00:00
|
|
|
TimeFunc: DefaultTime,
|
2018-08-24 23:40:41 +00:00
|
|
|
}
|
|
|
|
testCSV := `3.3,4,true,hello`
|
|
|
|
|
|
|
|
expectedTags := make(map[string]string)
|
|
|
|
expectedFields := map[string]interface{}{
|
|
|
|
"first": 3.3,
|
|
|
|
"second": 4,
|
|
|
|
"third": true,
|
|
|
|
"fourth": "hello",
|
|
|
|
}
|
|
|
|
|
|
|
|
metrics, err := p.Parse([]byte(testCSV))
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
expectedMetric, err1 := metric.New("test_value", expectedTags, expectedFields, time.Unix(0, 0))
|
|
|
|
returnedMetric, err2 := metric.New(metrics[0].Name(), metrics[0].Tags(), metrics[0].Fields(), time.Unix(0, 0))
|
|
|
|
require.NoError(t, err1)
|
|
|
|
require.NoError(t, err2)
|
|
|
|
|
|
|
|
//deep equal fields
|
|
|
|
require.Equal(t, expectedMetric.Fields(), returnedMetric.Fields())
|
2018-10-04 01:19:44 +00:00
|
|
|
|
|
|
|
// Test explicit type conversion.
|
|
|
|
p.ColumnTypes = []string{"float", "int", "bool", "string"}
|
|
|
|
|
|
|
|
metrics, err = p.Parse([]byte(testCSV))
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
returnedMetric, err2 = metric.New(metrics[0].Name(), metrics[0].Tags(), metrics[0].Fields(), time.Unix(0, 0))
|
|
|
|
require.NoError(t, err2)
|
|
|
|
|
|
|
|
//deep equal fields
|
|
|
|
require.Equal(t, expectedMetric.Fields(), returnedMetric.Fields())
|
2018-08-24 23:40:41 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
func TestSkipComment(t *testing.T) {
|
|
|
|
p := Parser{
|
|
|
|
HeaderRowCount: 0,
|
|
|
|
Comment: "#",
|
|
|
|
ColumnNames: []string{"first", "second", "third", "fourth"},
|
|
|
|
MetricName: "test_value",
|
2018-09-18 16:23:45 +00:00
|
|
|
TimeFunc: DefaultTime,
|
2018-08-24 23:40:41 +00:00
|
|
|
}
|
|
|
|
testCSV := `#3.3,4,true,hello
|
|
|
|
4,9.9,true,name_this`
|
|
|
|
|
|
|
|
expectedFields := map[string]interface{}{
|
|
|
|
"first": int64(4),
|
|
|
|
"second": 9.9,
|
|
|
|
"third": true,
|
|
|
|
"fourth": "name_this",
|
|
|
|
}
|
|
|
|
|
|
|
|
metrics, err := p.Parse([]byte(testCSV))
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, expectedFields, metrics[0].Fields())
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestTrimSpace(t *testing.T) {
|
|
|
|
p := Parser{
|
|
|
|
HeaderRowCount: 0,
|
|
|
|
TrimSpace: true,
|
|
|
|
ColumnNames: []string{"first", "second", "third", "fourth"},
|
|
|
|
MetricName: "test_value",
|
2018-09-18 16:23:45 +00:00
|
|
|
TimeFunc: DefaultTime,
|
2018-08-24 23:40:41 +00:00
|
|
|
}
|
|
|
|
testCSV := ` 3.3, 4, true,hello`
|
|
|
|
|
|
|
|
expectedFields := map[string]interface{}{
|
|
|
|
"first": 3.3,
|
|
|
|
"second": int64(4),
|
|
|
|
"third": true,
|
|
|
|
"fourth": "hello",
|
|
|
|
}
|
|
|
|
|
|
|
|
metrics, err := p.Parse([]byte(testCSV))
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, expectedFields, metrics[0].Fields())
|
|
|
|
}
|
|
|
|
|
2019-12-11 19:25:35 +00:00
|
|
|
func TestTrimSpaceDelimetedBySpace(t *testing.T) {
|
|
|
|
p := Parser{
|
|
|
|
Delimiter: " ",
|
|
|
|
HeaderRowCount: 1,
|
|
|
|
TrimSpace: true,
|
|
|
|
TimeFunc: DefaultTime,
|
|
|
|
}
|
|
|
|
testCSV := ` first second third fourth
|
|
|
|
abcdefgh 0 2 false
|
|
|
|
abcdef 3.3 4 true
|
|
|
|
f 0 2 false`
|
|
|
|
|
|
|
|
expectedFields := map[string]interface{}{
|
|
|
|
"first": "abcdef",
|
|
|
|
"second": 3.3,
|
|
|
|
"third": int64(4),
|
|
|
|
"fourth": true,
|
|
|
|
}
|
|
|
|
|
|
|
|
metrics, err := p.Parse([]byte(testCSV))
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, expectedFields, metrics[1].Fields())
|
|
|
|
}
|
|
|
|
|
2018-08-24 23:40:41 +00:00
|
|
|
func TestSkipRows(t *testing.T) {
|
|
|
|
p := Parser{
|
|
|
|
HeaderRowCount: 1,
|
|
|
|
SkipRows: 1,
|
|
|
|
TagColumns: []string{"line1"},
|
|
|
|
MeasurementColumn: "line3",
|
2018-09-18 16:23:45 +00:00
|
|
|
TimeFunc: DefaultTime,
|
2018-08-24 23:40:41 +00:00
|
|
|
}
|
|
|
|
testCSV := `garbage nonsense
|
|
|
|
line1,line2,line3
|
|
|
|
hello,80,test_name2`
|
|
|
|
|
|
|
|
expectedFields := map[string]interface{}{
|
|
|
|
"line2": int64(80),
|
|
|
|
"line3": "test_name2",
|
|
|
|
}
|
|
|
|
metrics, err := p.Parse([]byte(testCSV))
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, expectedFields, metrics[0].Fields())
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestSkipColumns(t *testing.T) {
|
|
|
|
p := Parser{
|
|
|
|
SkipColumns: 1,
|
|
|
|
ColumnNames: []string{"line1", "line2"},
|
2018-09-18 16:23:45 +00:00
|
|
|
TimeFunc: DefaultTime,
|
2018-08-24 23:40:41 +00:00
|
|
|
}
|
|
|
|
testCSV := `hello,80,test_name`
|
|
|
|
|
|
|
|
expectedFields := map[string]interface{}{
|
|
|
|
"line1": int64(80),
|
|
|
|
"line2": "test_name",
|
|
|
|
}
|
|
|
|
metrics, err := p.Parse([]byte(testCSV))
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, expectedFields, metrics[0].Fields())
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestSkipColumnsWithHeader(t *testing.T) {
|
|
|
|
p := Parser{
|
|
|
|
SkipColumns: 1,
|
|
|
|
HeaderRowCount: 2,
|
2018-09-18 16:23:45 +00:00
|
|
|
TimeFunc: DefaultTime,
|
2018-08-24 23:40:41 +00:00
|
|
|
}
|
|
|
|
testCSV := `col,col,col
|
|
|
|
1,2,3
|
|
|
|
trash,80,test_name`
|
|
|
|
|
|
|
|
// we should expect an error if we try to get col1
|
|
|
|
metrics, err := p.Parse([]byte(testCSV))
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Equal(t, map[string]interface{}{"col2": int64(80), "col3": "test_name"}, metrics[0].Fields())
|
|
|
|
}
|
2018-09-18 16:23:45 +00:00
|
|
|
|
|
|
|
func TestParseStream(t *testing.T) {
|
|
|
|
p := Parser{
|
|
|
|
MetricName: "csv",
|
|
|
|
HeaderRowCount: 1,
|
|
|
|
TimeFunc: DefaultTime,
|
|
|
|
}
|
|
|
|
|
|
|
|
csvHeader := "a,b,c"
|
|
|
|
csvBody := "1,2,3"
|
|
|
|
|
|
|
|
metrics, err := p.Parse([]byte(csvHeader))
|
|
|
|
require.NoError(t, err)
|
|
|
|
require.Len(t, metrics, 0)
|
|
|
|
metric, err := p.ParseLine(csvBody)
|
|
|
|
testutil.RequireMetricEqual(t,
|
|
|
|
testutil.MustMetric(
|
|
|
|
"csv",
|
|
|
|
map[string]string{},
|
|
|
|
map[string]interface{}{
|
|
|
|
"a": int64(1),
|
|
|
|
"b": int64(2),
|
|
|
|
"c": int64(3),
|
|
|
|
},
|
|
|
|
DefaultTime(),
|
|
|
|
), metric)
|
|
|
|
}
|
2019-05-14 18:29:44 +00:00
|
|
|
|
|
|
|
func TestTimestampUnixFloatPrecision(t *testing.T) {
|
|
|
|
p := Parser{
|
|
|
|
MetricName: "csv",
|
|
|
|
ColumnNames: []string{"time", "value"},
|
|
|
|
TimestampColumn: "time",
|
|
|
|
TimestampFormat: "unix",
|
|
|
|
TimeFunc: DefaultTime,
|
|
|
|
}
|
|
|
|
data := `1551129661.95456123352050781250,42`
|
|
|
|
|
|
|
|
expected := []telegraf.Metric{
|
|
|
|
testutil.MustMetric(
|
|
|
|
"csv",
|
|
|
|
map[string]string{},
|
|
|
|
map[string]interface{}{
|
|
|
|
"value": 42,
|
|
|
|
"time": 1551129661.954561233,
|
|
|
|
},
|
|
|
|
time.Unix(1551129661, 954561233),
|
|
|
|
),
|
|
|
|
}
|
|
|
|
|
|
|
|
metrics, err := p.Parse([]byte(data))
|
|
|
|
require.NoError(t, err)
|
|
|
|
testutil.RequireMetricsEqual(t, expected, metrics)
|
|
|
|
}
|