From 0ae5075cc9e812e4059eec321bcf2f8115add3b2 Mon Sep 17 00:00:00 2001 From: JP Date: Thu, 13 Aug 2015 20:42:57 -0500 Subject: [PATCH] fix tests, remove debug prints --- outputs/datadog/datadog.go | 2 -- outputs/datadog/datadog_test.go | 16 ++++++++++++---- 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/outputs/datadog/datadog.go b/outputs/datadog/datadog.go index 036f4c958..b79d1c828 100644 --- a/outputs/datadog/datadog.go +++ b/outputs/datadog/datadog.go @@ -78,9 +78,7 @@ func (d *Datadog) Write(bp client.BatchPoints) error { } req.Header.Add("Content-Type", "application/json") - fmt.Printf("making POST call\n") resp, err := d.client.Do(req) - fmt.Printf("POST call made, err is: %+v\n", err) defer resp.Body.Close() if err != nil { return fmt.Errorf("error POSTing metrics, %s\n", err.Error()) diff --git a/outputs/datadog/datadog_test.go b/outputs/datadog/datadog_test.go index 8f637d03c..744afc99b 100644 --- a/outputs/datadog/datadog_test.go +++ b/outputs/datadog/datadog_test.go @@ -30,7 +30,9 @@ func testData() client.BatchPoints { bp.Time = time.Now() bp.Tags = map[string]string{"tag1": "value1"} bp.Points = []client.Point{ - Fields: map[string]interface{}{"value": 1.0}, + { + Fields: map[string]interface{}{"value": 1.0}, + }, } return bp } @@ -43,7 +45,10 @@ func TestUriOverride(t *testing.T) { defer ts.Close() d := NewDatadog(ts.URL) - err := d.Write(testData()) + d.Apikey = "123456" + err := d.Connect() + require.NoError(t, err) + err = d.Write(testData()) require.NoError(t, err) } @@ -59,11 +64,14 @@ func TestBadStatusCode(t *testing.T) { defer ts.Close() d := NewDatadog(ts.URL) - err := d.Write(testData()) + d.Apikey = "123456" + err := d.Connect() + require.NoError(t, err) + err = d.Write(testData()) if err == nil { t.Errorf("error expected but none returned") } else { - require.EqualError(t, fmt.Errorf("error POSTing metrics, "), err.Error()) + require.EqualError(t, fmt.Errorf("received bad status code, 500\n"), err.Error()) } }