dom
/
telegraf
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

statsd input plugin correctly handles colons in data-dog tag values now (#1794) 

* Code correctly handles colons in tag values now

* Modified existing datadog tag test to include a tag value containing a colon
This commit is contained in:
Rikaard Hosein 2016-09-21 09:37:42 -04:00 committed by Cameron Sparr
parent f12368698b
commit 100501ba72
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/inputs/statsd/statsd.go
View File

@ -348,7 +348,7 @@ func (s *Statsd) parseStatsdLine(line string) error {
tagstr := segment[1:] tagstr := segment[1:]
tags := strings.Split(tagstr, ",") tags := strings.Split(tagstr, ",")
for _, tag := range tags { for _, tag := range tags {
ts := strings.Split(tag, ":") ts := strings.SplitN(tag, ":", 2)
var k, v string var k, v string
switch len(ts) { switch len(ts) {
case 1: case 1:

3
plugins/inputs/statsd/statsd_test.go
View File

@ -693,7 +693,7 @@ func TestParse_DataDogTags(t *testing.T) {
s.ParseDataDogTags = true s.ParseDataDogTags = true
lines := []string{ lines := []string{
"my_counter:1|c|#host:localhost,environment:prod", "my_counter:1|c|#host:localhost,environment:prod,endpoint:/:tenant?/oauth/ro",
"my_gauge:10.1|g|#live", "my_gauge:10.1|g|#live",
"my_set:1|s|#host:localhost", "my_set:1|s|#host:localhost",
"my_timer:3|ms|@0.1|#live,host:localhost", "my_timer:3|ms|@0.1|#live,host:localhost",
@ -703,6 +703,7 @@ func TestParse_DataDogTags(t *testing.T) {
"my_counter": map[string]string{ "my_counter": map[string]string{
"host": "localhost", "host": "localhost",
"environment": "prod", "environment": "prod",
"endpoint": "/:tenant?/oauth/ro",
}, },
"my_gauge": map[string]string{ "my_gauge": map[string]string{