Add support for timing sums in statsd input (#3234)

This commit is contained in:
Trevor Pounds 2017-09-14 18:21:54 -04:00 committed by Daniel Nelson
parent 875ab3c4b7
commit 171332c579
4 changed files with 18 additions and 1 deletions

View File

@ -143,6 +143,8 @@ metric type:
for that stat during that interval. for that stat during that interval.
- `statsd_<name>_stddev`: The stddev is the sample standard deviation - `statsd_<name>_stddev`: The stddev is the sample standard deviation
of all values statsd saw for that stat during that interval. of all values statsd saw for that stat during that interval.
- `statsd_<name>_sum`: The sum is the sample sum of all values statsd saw
for that stat during that interval.
- `statsd_<name>_count`: The count is the number of timings statsd saw - `statsd_<name>_count`: The count is the number of timings statsd saw
for that stat during that interval. It is not averaged. for that stat during that interval. It is not averaged.
- `statsd_<name>_percentile_<P>` The `Pth` percentile is a value x such - `statsd_<name>_percentile_<P>` The `Pth` percentile is a value x such

View File

@ -24,8 +24,10 @@ type RunningStats struct {
perc []float64 perc []float64
PercLimit int PercLimit int
upper float64 sum float64
lower float64 lower float64
upper float64
// cache if we have sorted the list so that we never re-sort a sorted list, // cache if we have sorted the list so that we never re-sort a sorted list,
// which can have very bad performance. // which can have very bad performance.
@ -51,6 +53,9 @@ func (rs *RunningStats) AddValue(v float64) {
rs.ex += v - rs.k rs.ex += v - rs.k
rs.ex2 += (v - rs.k) * (v - rs.k) rs.ex2 += (v - rs.k) * (v - rs.k)
// add to running sum
rs.sum += v
// track upper and lower bounds // track upper and lower bounds
if v > rs.upper { if v > rs.upper {
rs.upper = v rs.upper = v
@ -78,6 +83,10 @@ func (rs *RunningStats) Stddev() float64 {
return math.Sqrt(rs.Variance()) return math.Sqrt(rs.Variance())
} }
func (rs *RunningStats) Sum() float64 {
return rs.sum
}
func (rs *RunningStats) Upper() float64 { func (rs *RunningStats) Upper() float64 {
return rs.upper return rs.upper
} }

View File

@ -235,6 +235,7 @@ func (s *Statsd) Gather(acc telegraf.Accumulator) error {
} }
fields[prefix+"mean"] = stats.Mean() fields[prefix+"mean"] = stats.Mean()
fields[prefix+"stddev"] = stats.Stddev() fields[prefix+"stddev"] = stats.Stddev()
fields[prefix+"sum"] = stats.Sum()
fields[prefix+"upper"] = stats.Upper() fields[prefix+"upper"] = stats.Upper()
fields[prefix+"lower"] = stats.Lower() fields[prefix+"lower"] = stats.Lower()
fields[prefix+"count"] = stats.Count() fields[prefix+"count"] = stats.Count()

View File

@ -407,6 +407,7 @@ func TestParse_Timings(t *testing.T) {
"lower": float64(1), "lower": float64(1),
"mean": float64(3), "mean": float64(3),
"stddev": float64(4), "stddev": float64(4),
"sum": float64(15),
"upper": float64(11), "upper": float64(11),
} }
@ -1154,6 +1155,7 @@ func TestParse_Timings_MultipleFieldsWithTemplate(t *testing.T) {
"success_lower": float64(1), "success_lower": float64(1),
"success_mean": float64(3), "success_mean": float64(3),
"success_stddev": float64(4), "success_stddev": float64(4),
"success_sum": float64(15),
"success_upper": float64(11), "success_upper": float64(11),
"error_90_percentile": float64(22), "error_90_percentile": float64(22),
@ -1161,6 +1163,7 @@ func TestParse_Timings_MultipleFieldsWithTemplate(t *testing.T) {
"error_lower": float64(2), "error_lower": float64(2),
"error_mean": float64(6), "error_mean": float64(6),
"error_stddev": float64(8), "error_stddev": float64(8),
"error_sum": float64(30),
"error_upper": float64(22), "error_upper": float64(22),
} }
@ -1203,6 +1206,7 @@ func TestParse_Timings_MultipleFieldsWithoutTemplate(t *testing.T) {
"lower": float64(1), "lower": float64(1),
"mean": float64(3), "mean": float64(3),
"stddev": float64(4), "stddev": float64(4),
"sum": float64(15),
"upper": float64(11), "upper": float64(11),
} }
expectedError := map[string]interface{}{ expectedError := map[string]interface{}{
@ -1211,6 +1215,7 @@ func TestParse_Timings_MultipleFieldsWithoutTemplate(t *testing.T) {
"lower": float64(2), "lower": float64(2),
"mean": float64(6), "mean": float64(6),
"stddev": float64(8), "stddev": float64(8),
"sum": float64(30),
"upper": float64(22), "upper": float64(22),
} }