From 20bb673a0e7edb8c3725120a95a230e0a429346d Mon Sep 17 00:00:00 2001
From: Nick Neisen <nwneisen@gmail.com>
Date: Wed, 13 Nov 2019 14:00:41 -0700
Subject: [PATCH] Add a nameable file tag to file input plugin (#6650)

---
 plugins/inputs/file/README.md    |  5 +++++
 plugins/inputs/file/file.go      | 13 +++++++++++--
 plugins/inputs/file/file_test.go | 28 ++++++++++++++++++++++++++++
 3 files changed, 44 insertions(+), 2 deletions(-)

diff --git a/plugins/inputs/file/README.md b/plugins/inputs/file/README.md
index 4358b67ad..24139973b 100644
--- a/plugins/inputs/file/README.md
+++ b/plugins/inputs/file/README.md
@@ -7,6 +7,7 @@ Files will always be read in their entirety, if you wish to tail/follow a file
 use the [tail input plugin](/plugins/inputs/tail) instead.
 
 ### Configuration:
+
 ```toml
 [[inputs.file]]
   ## Files to parse each interval.
@@ -22,4 +23,8 @@ use the [tail input plugin](/plugins/inputs/tail) instead.
   ## more about them here:
   ## https://github.com/influxdata/telegraf/blob/master/docs/DATA_FORMATS_INPUT.md
   data_format = "influx"
+
+  ## Name a tag containing the name of the file the data was parsed from.  Leave empty
+  ## to disable.
+  # file_tag = ""
 ```
diff --git a/plugins/inputs/file/file.go b/plugins/inputs/file/file.go
index b93a7ba99..c601d4875 100644
--- a/plugins/inputs/file/file.go
+++ b/plugins/inputs/file/file.go
@@ -3,6 +3,7 @@ package file
 import (
 	"fmt"
 	"io/ioutil"
+	"path/filepath"
 
 	"github.com/influxdata/telegraf"
 	"github.com/influxdata/telegraf/internal/globpath"
@@ -11,8 +12,9 @@ import (
 )
 
 type File struct {
-	Files  []string `toml:"files"`
-	parser parsers.Parser
+	Files   []string `toml:"files"`
+	FileTag string   `toml:"file_tag"`
+	parser  parsers.Parser
 
 	filenames []string
 }
@@ -31,6 +33,10 @@ const sampleConfig = `
   ## more about them here:
   ## https://github.com/influxdata/telegraf/blob/master/docs/DATA_FORMATS_INPUT.md
   data_format = "influx"
+  
+  ## Name a tag containing the name of the file the data was parsed from.  Leave empty 
+  ## to disable.
+  # file_tag = ""
 `
 
 // SampleConfig returns the default configuration of the Input
@@ -54,6 +60,9 @@ func (f *File) Gather(acc telegraf.Accumulator) error {
 		}
 
 		for _, m := range metrics {
+			if f.FileTag != "" {
+				m.AddTag(f.FileTag, filepath.Base(k))
+			}
 			acc.AddFields(m.Name(), m.Fields(), m.Tags(), m.Time())
 		}
 	}
diff --git a/plugins/inputs/file/file_test.go b/plugins/inputs/file/file_test.go
index 43322c2e8..19341fc08 100644
--- a/plugins/inputs/file/file_test.go
+++ b/plugins/inputs/file/file_test.go
@@ -21,6 +21,34 @@ func TestRefreshFilePaths(t *testing.T) {
 	require.NoError(t, err)
 	assert.Equal(t, 2, len(r.filenames))
 }
+
+func TestFileTag(t *testing.T) {
+	acc := testutil.Accumulator{}
+	wd, err := os.Getwd()
+	require.NoError(t, err)
+	r := File{
+		Files:   []string{filepath.Join(wd, "dev/testfiles/json_a.log")},
+		FileTag: "filename",
+	}
+
+	parserConfig := parsers.Config{
+		DataFormat: "json",
+	}
+	nParser, err := parsers.NewParser(&parserConfig)
+	assert.NoError(t, err)
+	r.parser = nParser
+
+	err = r.Gather(&acc)
+	require.NoError(t, err)
+
+	for _, m := range acc.Metrics {
+		for key, value := range m.Tags {
+			assert.Equal(t, r.FileTag, key)
+			assert.Equal(t, filepath.Base(r.Files[0]), value)
+		}
+	}
+}
+
 func TestJSONParserCompile(t *testing.T) {
 	var acc testutil.Accumulator
 	wd, _ := os.Getwd()