Added zabbix output support

Makefile

@@ -83,6 +83,17 @@ endif
 	docker run --name mqtt -p "1883:1883" -d ncarlier/mqtt
 	docker run --name riemann -p "5555:5555" -d blalor/riemann
 	docker run --name snmp -p "31161:31161/udp" -d titilambert/snmpsim
+	docker run --name zabbix-db \
+		-e "MARIADB_USER=zabbix" \
+		-e "MARIADB_PASS=my_password" \
+		-d zabbix/zabbix-db-mariadb
+	docker run --name zabbix-server \
+		-p "10051:10051" \
+		--link zabbix-db:zabbix.db \
+		-e "ZS_DBHost=zabbix.db" \
+		-e "ZS_DBUser=zabbix" \
+		-e "ZS_DBPassword=my_password" \
+		-d zabbix/zabbix-server-2.4
 
 # Run docker containers necessary for CircleCI unit tests
 docker-run-circle:
@@ -97,11 +108,22 @@ docker-run-circle:
 	docker run --name mqtt -p "1883:1883" -d ncarlier/mqtt
 	docker run --name riemann -p "5555:5555" -d blalor/riemann
 	docker run --name snmp -p "31161:31161/udp" -d titilambert/snmpsim
+	docker run --name zabbix-db \
+		-e "MARIADB_USER=zabbix" \
+		-e "MARIADB_PASS=my_password" \
+		-d zabbix/zabbix-db-mariadb
+	docker run --name zabbix-server \
+		-p "10051:10051" \
+		--link zabbix-db:zabbix.db \
+		-e "ZS_DBHost=zabbix.db" \
+		-e "ZS_DBUser=zabbix" \
+		-e "ZS_DBPassword=my_password" \
+		-d zabbix/zabbix-server-2.4
 
 # Kill all docker containers, ignore errors
 docker-kill:
-	-docker kill nsq aerospike redis opentsdb rabbitmq postgres memcached mysql kafka mqtt riemann snmp
+	-docker kill nsq aerospike redis opentsdb rabbitmq postgres memcached mysql kafka mqtt riemann snmp zabbix-server zabbix-db
-	-docker rm nsq aerospike redis opentsdb rabbitmq postgres memcached mysql kafka mqtt riemann snmp
+	-docker rm nsq aerospike redis opentsdb rabbitmq postgres memcached mysql kafka mqtt riemann snmp zabbix-server zabbix-db
 
 # Run full unit tests using docker containers (includes setup and teardown)
 test: docker-kill docker-run

plugins/outputs/all/all.go

@@ -15,4 +15,5 @@ import (
 	_ "github.com/influxdata/telegraf/plugins/outputs/opentsdb"
 	_ "github.com/influxdata/telegraf/plugins/outputs/prometheus_client"
 	_ "github.com/influxdata/telegraf/plugins/outputs/riemann"
+	_ "github.com/influxdata/telegraf/plugins/outputs/zabbix"
 )

plugins/outputs/zabbix/zabbix.go

@@ -0,0 +1,199 @@
+package zabbix
+
+import (
+	"encoding/binary"
+	"encoding/json"
+	"fmt"
+	"net"
+	"os"
+	"strconv"
+	"time"
+
+	"github.com/influxdata/telegraf"
+	"github.com/influxdata/telegraf/plugins/outputs"
+)
+
+// ZabbixMetric class.
+type ZabbixMetric struct {
+	Host  string `json:"host"`
+	Key   string `json:"key"`
+	Value string `json:"value"`
+	Clock int64  `json:"clock"`
+}
+
+// ZabbixMetric class constructor.
+func NewZabbixMetric(host, key, value string, clock ...int64) *ZabbixMetric {
+	m := &ZabbixMetric{Host: host, Key: key, Value: value}
+	// use current time, if `clock` is not specified
+	if m.Clock = time.Now().Unix(); len(clock) > 0 {
+		m.Clock = int64(clock[0])
+	}
+	return m
+}
+
+// ZabbixPacket class.
+type ZabbixPacket struct {
+	Request string    `json:"request"`
+	Data    []*ZabbixMetric `json:"data"`
+	Clock   int64     `json:"clock"`
+}
+
+// ZabbixPacket class cunstructor.
+func NewZabbixPacket(data []*ZabbixMetric, clock ...int64) *ZabbixPacket {
+	p := &ZabbixPacket{Request: `sender data`, Data: data}
+	// use current time, if `clock` is not specified
+	if p.Clock = time.Now().Unix(); len(clock) > 0 {
+		p.Clock = int64(clock[0])
+	}
+	return p
+}
+
+// DataLen ZabbixPacket class method, return 8 bytes with packet length in little endian order.
+func (p *ZabbixPacket) DataLen() []byte {
+	dataLen := make([]byte, 8)
+	JSONData, _ := json.Marshal(p)
+	binary.LittleEndian.PutUint32(dataLen, uint32(len(JSONData)))
+	return dataLen
+}
+
+type Zabbix struct {
+	Host    string
+	Port    int
+	Hosttag string
+
+	Debug bool
+}
+
+var sampleConfig = `
+	# Address of zabbix host
+	host = "zabbix.example.com"
+	# Port of the Zabbix server
+	port = 10051
+	# Which tag will be used for measurement hostname
+	hosttag = "host"
+`
+
+func (z *Zabbix) Connect() error {
+	// Test connection to Zabbix server
+	// format: hostname:port
+	uri := fmt.Sprintf("%s:%d", z.Host, z.Port)
+	tcpAddr, err := net.ResolveTCPAddr("tcp", uri)
+	if err != nil {
+		return fmt.Errorf("Zabbix: TCP address cannot be resolved")
+	}
+
+	connection, err := net.DialTCP("tcp", nil, tcpAddr)
+	if err != nil {
+		return fmt.Errorf("Zabbix: Connection to Zabbix server failed")
+	}
+	defer connection.Close()
+	return nil
+}
+
+func (z *Zabbix) Write(metrics []telegraf.Metric) error {
+	if len(metrics) == 0 {
+		return nil
+	}
+	// Send Data to Zabbix server
+	uri := fmt.Sprintf("%s:%d", z.Host, z.Port)
+	tcpAddr, err := net.ResolveTCPAddr("tcp", uri)
+	if err != nil {
+		return fmt.Errorf("Zabbix: TCP address cannot be resolved")
+	}
+
+	connection, err := net.DialTCP("tcp", nil, tcpAddr)
+	if err != nil {
+		return fmt.Errorf("Zabbix: Connection to Zabbix server failed")
+	}
+	defer connection.Close()
+
+	var zabbixMetrics []*ZabbixMetric
+	var hostname string
+	for _, m := range metrics {
+		if h, ok := m.Tags()[z.Hosttag]; !ok {
+			if h, ok := m.Tags()["host"]; !ok {
+				h, err := os.Hostname()
+				if err != nil {
+					return fmt.Errorf("Cannot get os.Hostname()")
+				}
+				hostname = h
+			} else {
+				hostname = h
+			}
+		} else {
+			hostname = h
+		}
+		for fieldName, value := range m.Fields() {
+			metricValue, buildError := buildValue(value)
+			if buildError != nil {
+				fmt.Printf("Zabbix: %s\n", buildError.Error())
+			}
+			if z.Debug {
+				fmt.Printf("%s, %s, %s\n", hostname, fieldName, metricValue)
+			}
+
+			zabbixMetrics = append(zabbixMetrics, NewZabbixMetric(hostname, fieldName, metricValue))
+		}
+	}
+	packet := NewZabbixPacket(zabbixMetrics)
+	dataPacket, _ := json.Marshal(packet)
+
+	buffer := append(z.getHeader(), packet.DataLen()...)
+	buffer = append(buffer, dataPacket...)
+
+	if _, err := connection.Write(buffer); err != nil {
+		return fmt.Errorf("Zabbix: Sender writing error %s", err.Error())
+	}
+
+	return nil
+}
+
+func buildValue(v interface{}) (string, error) {
+	var retv string
+	switch p := v.(type) {
+	case int64:
+		retv = IntToString(int64(p))
+	case uint64:
+		retv = UIntToString(uint64(p))
+	case float64:
+		retv = FloatToString(float64(p))
+	default:
+		return retv, fmt.Errorf("unexpected type %T with value %v for Zabbix", v, v)
+	}
+
+	return retv, nil
+}
+
+func IntToString(input_num int64) string {
+	return strconv.FormatInt(input_num, 10)
+}
+
+func UIntToString(input_num uint64) string {
+	return strconv.FormatUint(input_num, 10)
+}
+
+func FloatToString(input_num float64) string {
+	return strconv.FormatFloat(input_num, 'f', 6, 64)
+}
+
+func (z *Zabbix) getHeader() []byte {
+	return []byte("ZBXD\x01")
+}
+
+func (z *Zabbix) SampleConfig() string {
+	return sampleConfig
+}
+
+func (z *Zabbix) Description() string {
+	return "Configuration for sender to Zabbix server"
+}
+
+func (z *Zabbix) Close() error {
+	return nil
+}
+
+func init() {
+	outputs.Add("zabbix", func() telegraf.Output {
+		return &Zabbix{}
+	})
+}

plugins/outputs/zabbix/zabbix_test.go

@@ -0,0 +1,28 @@
+package zabbix
+
+import (
+	"testing"
+
+	"github.com/influxdata/telegraf/testutil"
+	"github.com/stretchr/testify/require"
+)
+
+func TestConnectAndWrite(t *testing.T) {
+	if testing.Short() {
+		t.Skip("Skipping integration test in short mode")
+	}
+
+	host := testutil.GetLocalHost()
+
+	z := &Zabbix{
+		Host:    host,
+		Port:    10051,
+		Hosttag: "host",
+	}
+
+	err := z.Connect()
+	require.NoError(t, err)
+
+	err = z.Write(testutil.MockMetrics())
+	require.NoError(t, err)
+}