From 3509713a234ea56d82bc93c4ae53b5a85ba246e5 Mon Sep 17 00:00:00 2001 From: Mischa Gresser Date: Wed, 2 Dec 2015 13:20:31 -0500 Subject: [PATCH] Adding all memcached stats that return a single value as described at https://docs.oracle.com/cd/E17952_01/refman-5.0-en/ha-memcached-stats-general.html closes #412 --- plugins/memcached/memcached.go | 21 +++++++++++++++++++++ plugins/memcached/memcached_test.go | 7 ++++++- 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/plugins/memcached/memcached.go b/plugins/memcached/memcached.go index 3efa9f151..7186b1aae 100644 --- a/plugins/memcached/memcached.go +++ b/plugins/memcached/memcached.go @@ -33,6 +33,27 @@ var sendAsIs = []string{ "evictions", "limit_maxbytes", "bytes", + "uptime", + "curr_items", + "total_items", + "curr_connections", + "total_connections", + "connection_structures", + "cmd_get", + "cmd_set", + "delete_hits", + "delete_misses", + "incr_hits", + "incr_misses", + "decr_hits", + "decr_misses", + "cas_hits", + "cas_misses", + "evictions", + "bytes_read", + "bytes_written", + "threads", + "conn_yields", } // SampleConfig returns sample configuration message diff --git a/plugins/memcached/memcached_test.go b/plugins/memcached/memcached_test.go index 501fed1b9..0c0fdfbe1 100644 --- a/plugins/memcached/memcached_test.go +++ b/plugins/memcached/memcached_test.go @@ -22,7 +22,12 @@ func TestMemcachedGeneratesMetrics(t *testing.T) { err := m.Gather(&acc) require.NoError(t, err) - intMetrics := []string{"get_hits", "get_misses", "evictions", "limit_maxbytes", "bytes"} + intMetrics := []string{"get_hits", "get_misses", "evictions", + "limit_maxbytes", "bytes", "uptime", "curr_items", "total_items", + "curr_connections", "total_connections", "connection_structures", "cmd_get", + "cmd_set", "delete_hits", "delete_misses", "incr_hits", "incr_misses", + "decr_hits", "decr_misses", "cas_hits", "cas_misses", "evictions", + "bytes_read", "bytes_written", "threads", "conn_yields"} for _, metric := range intMetrics { assert.True(t, acc.HasIntValue(metric), metric)