From 3592433b0620c5826dc9200db65045c0d97c8a30 Mon Sep 17 00:00:00 2001 From: Greg <2653109+glinton@users.noreply.github.com> Date: Wed, 1 May 2019 17:46:52 -0600 Subject: [PATCH] Buffer metrics from failed writes in influxdb2 output if token is invalid (#5792) --- plugins/outputs/influxdb_v2/http.go | 5 +++-- plugins/outputs/influxdb_v2/influxdb.go | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/plugins/outputs/influxdb_v2/http.go b/plugins/outputs/influxdb_v2/http.go index cdc40c148..7bc9a4770 100644 --- a/plugins/outputs/influxdb_v2/http.go +++ b/plugins/outputs/influxdb_v2/http.go @@ -228,10 +228,11 @@ func (c *httpClient) writeBatch(ctx context.Context, bucket string, metrics []te } switch resp.StatusCode { - case http.StatusBadRequest, http.StatusUnauthorized, - http.StatusForbidden, http.StatusRequestEntityTooLarge: + case http.StatusBadRequest, http.StatusRequestEntityTooLarge: log.Printf("E! [outputs.influxdb_v2] Failed to write metric: %s\n", desc) return nil + case http.StatusUnauthorized, http.StatusForbidden: + return fmt.Errorf("failed to write metric: %s", desc) case http.StatusTooManyRequests, http.StatusServiceUnavailable: retryAfter := resp.Header.Get("Retry-After") retry, err := strconv.Atoi(retryAfter) diff --git a/plugins/outputs/influxdb_v2/influxdb.go b/plugins/outputs/influxdb_v2/influxdb.go index dca02b0cb..ff621fe9a 100644 --- a/plugins/outputs/influxdb_v2/influxdb.go +++ b/plugins/outputs/influxdb_v2/influxdb.go @@ -165,7 +165,7 @@ func (i *InfluxDB) Write(metrics []telegraf.Metric) error { log.Printf("E! [outputs.influxdb_v2] when writing to [%s]: %v", client.URL(), err) } - return errors.New("could not write any address") + return err } func (i *InfluxDB) getHTTPClient(ctx context.Context, url *url.URL, proxy *url.URL) (Client, error) {