From 4146f5f6dfc7f3fdeb3dd3b84baff6854f5b5a29 Mon Sep 17 00:00:00 2001
From: Evan Phoenix <evan@phx.io>
Date: Mon, 18 May 2015 15:50:09 -0700
Subject: [PATCH] Add ability to restrict which network interfaces are sampled

---
 plugins/system/system.go | 42 +++++++++++++++++++++++++++++++++++++++-
 tivan.toml               |  7 ++++++-
 2 files changed, 47 insertions(+), 2 deletions(-)

diff --git a/plugins/system/system.go b/plugins/system/system.go
index a224b7728..9f49832f3 100644
--- a/plugins/system/system.go
+++ b/plugins/system/system.go
@@ -147,13 +147,25 @@ func (s *DiskIOStats) Gather(acc plugins.Accumulator) error {
 
 type NetIOStats struct {
 	ps PS
+
+	Interfaces []string
 }
 
 func (_ *NetIOStats) Description() string {
 	return "Read metrics about network interface usage"
 }
 
-func (_ *NetIOStats) SampleConfig() string { return "" }
+var netSampleConfig = `
+# By default, tivan gathers stats from any up interface (excluding loopback)
+# Setting interfaces will tell it to gather these explicit interfaces,
+# regardless of status.
+#
+# interfaces = ["eth0", ... ]
+`
+
+func (_ *NetIOStats) SampleConfig() string {
+	return netSampleConfig
+}
 
 func (s *NetIOStats) Gather(acc plugins.Accumulator) error {
 	netio, err := s.ps.NetIO()
@@ -162,6 +174,34 @@ func (s *NetIOStats) Gather(acc plugins.Accumulator) error {
 	}
 
 	for _, io := range netio {
+		if len(s.Interfaces) != 0 {
+			var found bool
+
+			for _, name := range s.Interfaces {
+				if name == io.Name {
+					found = true
+					break
+				}
+			}
+
+			if !found {
+				continue
+			}
+		} else {
+			iface, err := gonet.InterfaceByName(io.Name)
+			if err != nil {
+				continue
+			}
+
+			if iface.Flags&gonet.FlagLoopback == gonet.FlagLoopback {
+				continue
+			}
+
+			if iface.Flags&gonet.FlagUp == 0 {
+				continue
+			}
+		}
+
 		tags := map[string]string{
 			"interface": io.Name,
 		}
diff --git a/tivan.toml b/tivan.toml
index 749d49ccb..21c692350 100644
--- a/tivan.toml
+++ b/tivan.toml
@@ -54,7 +54,12 @@ servers = ["localhost"]
 
 # Read metrics about network interface usage
 [net]
-  # no configuration
+
+# By default, tivan gathers stats from any up interface (excluding loopback)
+# Setting interfaces will tell it to gather these explicit interfaces,
+# regardless of status.
+#
+# interfaces = ["eth0", ... ]
 
 # Read metrics from one or many postgresql servers
 [postgresql]