From 431b3355ed4eac2a5e2b1a6a849712b3227f4160 Mon Sep 17 00:00:00 2001
From: Kit Ewbank <Kit.Ewbank@capitalone.com>
Date: Thu, 8 Sep 2016 11:42:41 -0400
Subject: [PATCH] Handle Telegraf metric types and sanitize names.

---
 plugins/outputs/signalfx/signalfx.go | 38 ++++++++++++++++++++++++----
 1 file changed, 33 insertions(+), 5 deletions(-)

diff --git a/plugins/outputs/signalfx/signalfx.go b/plugins/outputs/signalfx/signalfx.go
index 41a32d715..28ae0daf6 100644
--- a/plugins/outputs/signalfx/signalfx.go
+++ b/plugins/outputs/signalfx/signalfx.go
@@ -1,7 +1,9 @@
 package signalfx
 
 import (
+	"fmt"
 	"log"
+	"regexp"
 
 	"golang.org/x/net/context"
 
@@ -20,6 +22,8 @@ type SignalFx struct {
 	sink *sfxclient.HTTPDatapointSink
 }
 
+var invalidNameCharRE = regexp.MustCompile(`[^a-zA-Z0-9_]`)
+
 var sampleConfig = `
   ## Your organization's SignalFx API access token.
   auth_token = "SuperSecretToken"
@@ -59,21 +63,45 @@ func (s *SignalFx) Close() error {
 func (s *SignalFx) Write(metrics []telegraf.Metric) error {
 	var datapoints []*datapoint.Datapoint
 	for _, metric := range metrics {
+		// Sanitize metric name.
+		metricName := metric.Name()
+		metricName = invalidNameCharRE.ReplaceAllString(metricName, "_")
+
+		// Get a type if it's available, defaulting to Gauge.
+		var sfMetricType datapoint.MetricType
+		switch metric.Type() {
+		case telegraf.Counter:
+			sfMetricType = datapoint.Counter
+		case telegraf.Gauge:
+			sfMetricType = datapoint.Gauge
+		default:
+			sfMetricType = datapoint.Gauge
+		}
+
 		// One SignalFx metric per field.
 		for fieldName, fieldValue := range metric.Fields() {
-			var value datapoint.Value
+			var sfValue datapoint.Value
 			switch fieldValue.(type) {
 			case float64:
-				value = datapoint.NewFloatValue(fieldValue.(float64))
+				sfValue = datapoint.NewFloatValue(fieldValue.(float64))
 			case int64:
-				value = datapoint.NewIntValue(fieldValue.(int64))
+				sfValue = datapoint.NewIntValue(fieldValue.(int64))
 			default:
 				log.Printf("Unhandled type %T for field %s\n", fieldValue, fieldName)
 				continue
 			}
 
-			metricName := metric.Name() + "." + fieldName
-			datapoint := datapoint.New(metricName, metric.Tags(), value, datapoint.Gauge, metric.Time())
+			// Sanitize field name.
+			fieldName = invalidNameCharRE.ReplaceAllString(fieldName, "_")
+
+			var sfMetricName string
+			if fieldName == "value" {
+				sfMetricName = metricName
+			} else {
+				sfMetricName = fmt.Sprintf("%s.%s", metricName, fieldName)
+			}
+
+			datapoint := datapoint.New(sfMetricName, metric.Tags(), sfValue, sfMetricType, metric.Time())
 			datapoints = append(datapoints, datapoint)
 		}
 	}