dom/telegraf
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

resolves issues where failed api calls lead to obscure errors (#7051)

Browse Source
This commit is contained in:
Steven Soroka
2020-02-19 21:46:08 -05:00
committed by GitHub
parent 3058308d38
commit 5023df08d8
11 changed files with 97 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
plugins/inputs/ecs/client_test.go
View File

@@ -107,7 +107,8 @@ func TestEcsClient_Task(t *testing.T) {
client: mockDo{
do: func(req *http.Request) (*http.Response, error) {
return &http.Response{
Body: ioutil.NopCloser(rc),
StatusCode: http.StatusOK,
Body: ioutil.NopCloser(rc),
}, nil
},
},
@@ -123,11 +124,24 @@ func TestEcsClient_Task(t *testing.T) {
wantErr: true,
},
{
name: "malformed resp",
name: "malformed 500 resp",
client: mockDo{
do: func(req *http.Request) (*http.Response, error) {
return &http.Response{
Body: ioutil.NopCloser(bytes.NewReader([]byte("foo"))),
StatusCode: http.StatusInternalServerError,
Body: ioutil.NopCloser(bytes.NewReader([]byte("foo"))),
}, nil
},
},
wantErr: true,
},
{
name: "malformed 200 resp",
client: mockDo{
do: func(req *http.Request) (*http.Response, error) {
return &http.Response{
StatusCode: http.StatusOK,
Body: ioutil.NopCloser(bytes.NewReader([]byte("foo"))),
}, nil
},
},
@@ -164,7 +178,8 @@ func TestEcsClient_ContainerStats(t *testing.T) {
client: mockDo{
do: func(req *http.Request) (*http.Response, error) {
return &http.Response{
Body: ioutil.NopCloser(rc),
StatusCode: http.StatusOK,
Body: ioutil.NopCloser(rc),
}, nil
},
},
@@ -181,17 +196,31 @@ func TestEcsClient_ContainerStats(t *testing.T) {
wantErr: true,
},
{
name: "malformed resp",
name: "malformed 200 resp",
client: mockDo{
do: func(req *http.Request) (*http.Response, error) {
return &http.Response{
Body: ioutil.NopCloser(bytes.NewReader([]byte("foo"))),
StatusCode: http.StatusOK,
Body: ioutil.NopCloser(bytes.NewReader([]byte("foo"))),
}, nil
},
},
want: map[string]types.StatsJSON{},
wantErr: true,
},
{
name: "malformed 500 resp",
client: mockDo{
do: func(req *http.Request) (*http.Response, error) {
return &http.Response{
StatusCode: http.StatusInternalServerError,
Body: ioutil.NopCloser(bytes.NewReader([]byte("foo"))),
}, nil
},
},
want: nil,
wantErr: true,
},
}
for _, tt := range tests {