From 670277f7854a7c5bd6b530f2ca5cfa42067dac94 Mon Sep 17 00:00:00 2001
From: Darin Fisher <darinfisher@users.noreply.github.com>
Date: Tue, 12 May 2020 15:01:17 -0600
Subject: [PATCH] Add authentication support to the http_response input plugin
 (#7491)

---
 plugins/inputs/http_response/http_response.go | 42 +++++++++++++++----
 .../http_response/http_response_test.go       | 42 +++++++++++++++++++
 2 files changed, 76 insertions(+), 8 deletions(-)

diff --git a/plugins/inputs/http_response/http_response.go b/plugins/inputs/http_response/http_response.go
index 24c22f72f..7ba141c23 100644
--- a/plugins/inputs/http_response/http_response.go
+++ b/plugins/inputs/http_response/http_response.go
@@ -21,16 +21,21 @@ import (
 
 // HTTPResponse struct
 type HTTPResponse struct {
-	Address             string   // deprecated in 1.12
-	URLs                []string `toml:"urls"`
-	HTTPProxy           string   `toml:"http_proxy"`
-	Body                string
-	Method              string
-	ResponseTimeout     internal.Duration
-	Headers             map[string]string
-	FollowRedirects     bool
+	Address         string   // deprecated in 1.12
+	URLs            []string `toml:"urls"`
+	HTTPProxy       string   `toml:"http_proxy"`
+	Body            string
+	Method          string
+	ResponseTimeout internal.Duration
+	Headers         map[string]string
+	FollowRedirects bool
+	// Absolute path to file with Bearer token
+	BearerToken         string `toml:"bearer_token"`
 	ResponseStringMatch string
 	Interface           string
+	// HTTP Basic Auth Credentials
+	Username string `toml:"username"`
+	Password string `toml:"password"`
 	tls.ClientConfig
 
 	Log telegraf.Logger
@@ -64,6 +69,14 @@ var sampleConfig = `
   ## Whether to follow redirects from the server (defaults to false)
   # follow_redirects = false
 
+  ## Optional file with Bearer token
+  ## file content is added as an Authorization header
+  # bearer_token = "/path/to/file"
+
+  ## Optional HTTP Basic Auth Credentials
+  # username = "username"
+  # password = "pa$$word"
+
   ## Optional HTTP Request Body
   # body = '''
   # {'fake':'data'}
@@ -227,6 +240,15 @@ func (h *HTTPResponse) httpGather(u string) (map[string]interface{}, map[string]
 		return nil, nil, err
 	}
 
+	if h.BearerToken != "" {
+		token, err := ioutil.ReadFile(h.BearerToken)
+		if err != nil {
+			return nil, nil, err
+		}
+		bearer := "Bearer " + strings.Trim(string(token), "\n")
+		request.Header.Add("Authorization", bearer)
+	}
+
 	for key, val := range h.Headers {
 		request.Header.Add(key, val)
 		if key == "Host" {
@@ -234,6 +256,10 @@ func (h *HTTPResponse) httpGather(u string) (map[string]interface{}, map[string]
 		}
 	}
 
+	if h.Username != "" || h.Password != "" {
+		request.SetBasicAuth(h.Username, h.Password)
+	}
+
 	// Start Timer
 	start := time.Now()
 	resp, err := h.client.Do(request)
diff --git a/plugins/inputs/http_response/http_response_test.go b/plugins/inputs/http_response/http_response_test.go
index 530c81901..947fde5c8 100644
--- a/plugins/inputs/http_response/http_response_test.go
+++ b/plugins/inputs/http_response/http_response_test.go
@@ -864,3 +864,45 @@ func TestRedirect(t *testing.T) {
 
 	testutil.RequireMetricsEqual(t, expected, actual, testutil.IgnoreTime())
 }
+
+func TestBasicAuth(t *testing.T) {
+	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		aHeader := r.Header.Get("Authorization")
+		assert.Equal(t, "Basic bWU6bXlwYXNzd29yZA==", aHeader)
+		w.WriteHeader(http.StatusOK)
+	}))
+	defer ts.Close()
+
+	h := &HTTPResponse{
+		Log:             testutil.Logger{},
+		Address:         ts.URL + "/good",
+		Body:            "{ 'test': 'data'}",
+		Method:          "GET",
+		ResponseTimeout: internal.Duration{Duration: time.Second * 20},
+		Username:        "me",
+		Password:        "mypassword",
+		Headers: map[string]string{
+			"Content-Type": "application/json",
+		},
+	}
+
+	var acc testutil.Accumulator
+	err := h.Gather(&acc)
+	require.NoError(t, err)
+
+	expectedFields := map[string]interface{}{
+		"http_response_code": http.StatusOK,
+		"result_type":        "success",
+		"result_code":        0,
+		"response_time":      nil,
+		"content_length":     nil,
+	}
+	expectedTags := map[string]interface{}{
+		"server":      nil,
+		"method":      "GET",
+		"status_code": "200",
+		"result":      "success",
+	}
+	absentFields := []string{"response_string_match"}
+	checkOutput(t, &acc, expectedFields, expectedTags, absentFields, nil)
+}