address some of Daniel's comments

plugins/inputs/reader/reader.go

@@ -1,8 +1,8 @@
 package reader
 
 import (
+	"fmt"
 	"io/ioutil"
-	"log"
 
 	"github.com/influxdata/telegraf"
 	"github.com/influxdata/telegraf/internal/globpath"
@@ -50,14 +50,8 @@ func (r *Reader) Gather(acc telegraf.Accumulator) error {
 			return err
 		}
 
-		for i, m := range metrics {
-
-			//error if m is nil
-			if m == nil {
-				log.Printf("E! Metric could not be parsed from: %v, on line %v", k, i)
-				continue
-			}
-			acc.AddFields(m.Name(), m.Fields(), m.Tags())
+		for _, m := range metrics {
+			acc.AddFields(m.Name(), m.Fields(), m.Tags(), m.Time())
 		}
 	}
 	return nil
@@ -67,13 +61,12 @@ func (r *Reader) SetParser(p parsers.Parser) {
 	r.parser = p
 }
 
-func (r *Reader) refreshFilePaths() {
+func (r *Reader) refreshFilePaths() error {
 	var allFiles []string
 	for _, filepath := range r.Filepaths {
 		g, err := globpath.Compile(filepath)
 		if err != nil {
-			log.Printf("E! Error Glob %s failed to compile, %s", filepath, err)
-			continue
+			return fmt.Errorf("E! Error Glob: %v could not be compiled, %s", filepath, err)
 		}
 		files := g.Match()
 
@@ -83,13 +76,13 @@ func (r *Reader) refreshFilePaths() {
 	}
 
 	r.Filenames = allFiles
+	return nil
 }
 
-//requires that Parser has been compiled
 func (r *Reader) readMetric(filename string) ([]telegraf.Metric, error) {
 	fileContents, err := ioutil.ReadFile(filename)
 	if err != nil {
-		log.Printf("E! File could not be opened: %v", filename)
+		return nil, fmt.Errorf("E! Error file: %v could not be read, %s", filename, err)
 	}
 	return r.parser.Parse(fileContents)
 

plugins/parsers/grok/parser.go

@@ -71,7 +71,7 @@ type Parser struct {
 	NamedPatterns      []string
 	CustomPatterns     string
 	CustomPatternFiles []string
-	Measurement        string
+	MetricName         string
 
 	// Timezone is an optional component to help render log dates to
 	// your chosen zone.
@@ -167,10 +167,6 @@ func (p *Parser) Compile() error {
 		p.addCustomPatterns(scanner)
 	}
 
-	if p.Measurement == "" {
-		p.Measurement = "logparser_grok"
-	}
-
 	p.loc, err = time.LoadLocation(p.Timezone)
 	if err != nil {
 		log.Printf("W! improper timezone supplied (%s), setting loc to UTC", p.Timezone)
@@ -348,7 +344,7 @@ func (p *Parser) ParseLine(line string) (telegraf.Metric, error) {
 		return nil, fmt.Errorf("logparser_grok: must have one or more fields")
 	}
 
-	return metric.New(p.Measurement, tags, fields, p.tsModder.tsMod(timestamp))
+	return metric.New(p.MetricName, tags, fields, p.tsModder.tsMod(timestamp))
 }
 
 func (p *Parser) Parse(buf []byte) ([]telegraf.Metric, error) {

plugins/parsers/grok/parser_test.go

@@ -9,8 +9,8 @@ import (
 
 func TestGrokParse(t *testing.T) {
 	parser := Parser{
-		Measurement: "t_met",
-		Patterns:    []string{"%{COMMON_LOG_FORMAT}"},
+		MetricName: "t_met",
+		Patterns:   []string{"%{COMMON_LOG_FORMAT}"},
 	}
 	parser.Compile()
 	metrics, err := parser.Parse([]byte(`127.0.0.1 user-identifier frank [10/Oct/2000:13:55:36 -0700] "GET /apache_pb.gif HTTP/1.0" 200 2326`))

plugins/parsers/registry.go

@@ -148,7 +148,7 @@ func newGrokParser(metricName string,
 	cPatterns string,
 	cPatternFiles []string, tZone string) (Parser, error) {
 	parser := grok.Parser{
-		Measurement:        metricName,
+		MetricName:         metricName,
 		Patterns:           patterns,
 		NamedPatterns:      nPatterns,
 		CustomPatterns:     cPatterns,