From 8d04cb76fd07f3b5998f4d1ea7fd7d29d99f1927 Mon Sep 17 00:00:00 2001
From: George <me+github@georgemac.com>
Date: Wed, 19 Jun 2019 21:40:53 +0100
Subject: [PATCH] Add support for interface field in http_response input plugin
 (#6006)

---
 plugins/inputs/http_response/README.md        |  3 +
 plugins/inputs/http_response/http_response.go | 38 ++++++++++-
 .../http_response/http_response_test.go       | 63 +++++++++++++++++++
 3 files changed, 103 insertions(+), 1 deletion(-)

diff --git a/plugins/inputs/http_response/README.md b/plugins/inputs/http_response/README.md
index 54e229b30..38d527fb0 100644
--- a/plugins/inputs/http_response/README.md
+++ b/plugins/inputs/http_response/README.md
@@ -46,6 +46,9 @@ This input plugin checks HTTP/HTTPS connections.
   ## HTTP Request Headers (all values must be strings)
   # [inputs.http_response.headers]
   #   Host = "github.com"
+
+  ## Interface to use when dialing an address
+  # interface = "eth0"
 ```
 
 ### Metrics:
diff --git a/plugins/inputs/http_response/http_response.go b/plugins/inputs/http_response/http_response.go
index 7dbe47b0d..a9d82f13d 100644
--- a/plugins/inputs/http_response/http_response.go
+++ b/plugins/inputs/http_response/http_response.go
@@ -31,6 +31,7 @@ type HTTPResponse struct {
 	Headers             map[string]string
 	FollowRedirects     bool
 	ResponseStringMatch string
+	Interface           string
 	tls.ClientConfig
 
 	compiledStringMatch *regexp.Regexp
@@ -82,6 +83,9 @@ var sampleConfig = `
   ## HTTP Request Headers (all values must be strings)
   # [inputs.http_response.headers]
   #   Host = "github.com"
+
+  ## Interface to use when dialing an address
+  # interface = "eth0"
 `
 
 // SampleConfig returns the plugin SampleConfig
@@ -108,16 +112,27 @@ func getProxyFunc(http_proxy string) func(*http.Request) (*url.URL, error) {
 	}
 }
 
-// CreateHttpClient creates an http client which will timeout at the specified
+// createHttpClient creates an http client which will timeout at the specified
 // timeout period and can follow redirects if specified
 func (h *HTTPResponse) createHttpClient() (*http.Client, error) {
 	tlsCfg, err := h.ClientConfig.TLSConfig()
 	if err != nil {
 		return nil, err
 	}
+
+	dialer := &net.Dialer{}
+
+	if h.Interface != "" {
+		dialer.LocalAddr, err = localAddress(h.Interface)
+		if err != nil {
+			return nil, err
+		}
+	}
+
 	client := &http.Client{
 		Transport: &http.Transport{
 			Proxy:             getProxyFunc(h.HTTPProxy),
+			DialContext:       dialer.DialContext,
 			DisableKeepAlives: true,
 			TLSClientConfig:   tlsCfg,
 		},
@@ -132,6 +147,27 @@ func (h *HTTPResponse) createHttpClient() (*http.Client, error) {
 	return client, nil
 }
 
+func localAddress(interfaceName string) (net.Addr, error) {
+	i, err := net.InterfaceByName(interfaceName)
+	if err != nil {
+		return nil, err
+	}
+
+	addrs, err := i.Addrs()
+	if err != nil {
+		return nil, err
+	}
+
+	for _, addr := range addrs {
+		if naddr, ok := addr.(*net.IPNet); ok {
+			// leaving port set to zero to let kernel pick
+			return &net.TCPAddr{IP: naddr.IP}, nil
+		}
+	}
+
+	return nil, fmt.Errorf("cannot create local address for interface %q", interfaceName)
+}
+
 func setResult(result_string string, fields map[string]interface{}, tags map[string]string) {
 	result_codes := map[string]int{
 		"success":                  0,
diff --git a/plugins/inputs/http_response/http_response_test.go b/plugins/inputs/http_response/http_response_test.go
index a33805db3..159eaa562 100644
--- a/plugins/inputs/http_response/http_response_test.go
+++ b/plugins/inputs/http_response/http_response_test.go
@@ -1,8 +1,10 @@
 package http_response
 
 import (
+	"errors"
 	"fmt"
 	"io/ioutil"
+	"net"
 	"net/http"
 	"net/http/httptest"
 	"testing"
@@ -210,6 +212,67 @@ func TestFields(t *testing.T) {
 	checkOutput(t, &acc, expectedFields, expectedTags, absentFields, nil)
 }
 
+func findInterface() (net.Interface, error) {
+	potential, _ := net.Interfaces()
+
+	for _, i := range potential {
+		// we are only interest in loopback interfaces which are up
+		if (i.Flags&net.FlagUp == 0) || (i.Flags&net.FlagLoopback == 0) {
+			continue
+		}
+
+		if addrs, _ := i.Addrs(); len(addrs) > 0 {
+			// return interface if it has at least one unicast address
+			return i, nil
+		}
+	}
+
+	return net.Interface{}, errors.New("cannot find suitable loopback interface")
+}
+
+func TestInterface(t *testing.T) {
+	var (
+		mux = setUpTestMux()
+		ts  = httptest.NewServer(mux)
+	)
+
+	defer ts.Close()
+
+	intf, err := findInterface()
+	require.NoError(t, err)
+
+	h := &HTTPResponse{
+		Address:         ts.URL + "/good",
+		Body:            "{ 'test': 'data'}",
+		Method:          "GET",
+		ResponseTimeout: internal.Duration{Duration: time.Second * 20},
+		Headers: map[string]string{
+			"Content-Type": "application/json",
+		},
+		FollowRedirects: true,
+		Interface:       intf.Name,
+	}
+
+	var acc testutil.Accumulator
+	err = h.Gather(&acc)
+	require.NoError(t, err)
+
+	expectedFields := map[string]interface{}{
+		"http_response_code": http.StatusOK,
+		"result_type":        "success",
+		"result_code":        0,
+		"response_time":      nil,
+	}
+	expectedTags := map[string]interface{}{
+		"server":      nil,
+		"method":      "GET",
+		"status_code": "200",
+		"result":      "success",
+	}
+	absentFields := []string{"response_string_match"}
+	checkOutput(t, &acc, expectedFields, expectedTags, absentFields, nil)
+}
+
 func TestRedirects(t *testing.T) {
 	mux := setUpTestMux()
 	ts := httptest.NewServer(mux)