dom/telegraf
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use random available port in prometheus output tests (#5555)

Browse Source
This commit is contained in:
Daniel Nelson
2019-03-08 14:54:16 -08:00
committed by GitHub
parent bdb9d5c842
commit 91cd17fd40
2 changed files with 35 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
plugins/outputs/prometheus_client/prometheus_client_tls_test.go
View File

@@ -3,25 +3,26 @@ package prometheus_client_test
import (
"crypto/tls"
"fmt"
"net/http"
"testing"
"github.com/influxdata/telegraf/plugins/outputs/prometheus_client"
"github.com/influxdata/telegraf/testutil"
"github.com/influxdata/toml"
"github.com/stretchr/testify/require"
"net/http"
"testing"
)
var pki = testutil.NewPKI("../../../testutil/pki")
var configWithTLS = fmt.Sprintf(`
listen = "127.0.0.1:9090"
listen = "127.0.0.1:0"
tls_allowed_cacerts = ["%s"]
tls_cert = "%s"
tls_key = "%s"
`, pki.TLSServerConfig().TLSAllowedCACerts[0], pki.TLSServerConfig().TLSCert, pki.TLSServerConfig().TLSKey)
var configWithoutTLS = `
listen = "127.0.0.1:9090"
listen = "127.0.0.1:0"
`
type PrometheusClientTestContext struct {
@@ -33,11 +34,10 @@ type PrometheusClientTestContext struct {
func TestWorksWithoutTLS(t *testing.T) {
tc := buildTestContext(t, []byte(configWithoutTLS))
err := tc.Output.Connect()
require.NoError(t, err)
defer tc.Output.Close()
require.NoError(t, err)
response, err := tc.Client.Get("http://localhost:9090/metrics")
response, err := tc.Client.Get(tc.Output.URL())
require.NoError(t, err)
require.NoError(t, err)
@@ -47,24 +47,21 @@ func TestWorksWithoutTLS(t *testing.T) {
func TestWorksWithTLS(t *testing.T) {
tc := buildTestContext(t, []byte(configWithTLS))
err := tc.Output.Connect()
defer tc.Output.Close()
require.NoError(t, err)
defer tc.Output.Close()
response, err := tc.Client.Get("https://localhost:9090/metrics")
response, err := tc.Client.Get(tc.Output.URL())
require.NoError(t, err)
require.NoError(t, err)
require.Equal(t, response.StatusCode, http.StatusOK)
response, err = tc.Client.Get("http://localhost:9090/metrics")
require.Error(t, err)
tr := &http.Transport{
TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
}
client := &http.Client{Transport: tr}
response, err = client.Get("https://localhost:9090/metrics")
response, err = client.Get(tc.Output.URL())
require.Error(t, err)
}