dom
/
telegraf
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix how major and minor identifiers of block devices are read. 

The current implementation assure that the major and the minor are
coded on one byte. But they are not:

```
brw-rw----  1 root disk    252, 290 Feb 25 11:36 dm-290
```

290 as minor in this example is over 1 byte.

So after wondering why all my devices iops weren't correctly stored,
I found out that several points were added for some disks. For `dm-290`
it was overriding `252:34`, instead of getting udev stats for `252:290`.

The solution is here:
https://sites.uclouvain.be/SystInfo/usr/include/sys/sysmacros.h.html

The implementation is directly taken from this, fixing my bug.
This commit is contained in:
Soulou 2019-03-11 01:21:30 +01:00
parent 91cd17fd40
commit 92b01ab4f9
No known key found for this signature in database
GPG Key ID: 9FC511C0EC98B9DA
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/inputs/diskio/diskio_linux.go
View File

@ -36,7 +36,7 @@ func (s *DiskIO) diskInfo(devName string) (map[string]string, error) {
} }
major := stat.Rdev >> 8 & 0xff major := stat.Rdev >> 8 & 0xff
minor := stat.Rdev & 0xff minor := (stat.Rdev & 0xff) | (stat.Rdev>>12)&^0xff
udevDataPath := fmt.Sprintf("%s/b%d:%d", udevPath, major, minor) udevDataPath := fmt.Sprintf("%s/b%d:%d", udevPath, major, minor)
di := map[string]string{} di := map[string]string{}