dom
/
telegraf
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix scale set resource id with azure_monitor output (#5821)

This commit is contained in:
Daniel Nelson 2019-05-20 14:32:04 -07:00 committed by GitHub
parent 9cdf1ea56e
commit ad877fdd91
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 39 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

62
plugins/outputs/azure_monitor/azure_monitor.go
View File

@ -43,6 +43,35 @@ type AzureMonitor struct {
MetricOutsideWindow selfstat.Stat MetricOutsideWindow selfstat.Stat
} }
// VirtualMachineMetadata contains information about a VM from the metadata service
type virtualMachineMetadata struct {
Compute struct {
Location string `json:"location"`
Name string `json:"name"`
ResourceGroupName string `json:"resourceGroupName"`
SubscriptionID string `json:"subscriptionId"`
VMScaleSetName string `json:"vmScaleSetName"`
} `json:"compute"`
}
func (m *virtualMachineMetadata) ResourceID() string {
if m.Compute.VMScaleSetName != "" {
return fmt.Sprintf(
resourceIDScaleSetTemplate,
m.Compute.SubscriptionID,
m.Compute.ResourceGroupName,
m.Compute.VMScaleSetName,
)
} else {
return fmt.Sprintf(
resourceIDTemplate,
m.Compute.SubscriptionID,
m.Compute.ResourceGroupName,
m.Compute.Name,
)
}
}
type dimension struct { type dimension struct {
name string name string
value string value string
@ -63,11 +92,12 @@ const (
defaultNamespacePrefix = "Telegraf/" defaultNamespacePrefix = "Telegraf/"
defaultAuthResource = "https://monitoring.azure.com/" defaultAuthResource = "https://monitoring.azure.com/"
vmInstanceMetadataURL = "http://169.254.169.254/metadata/instance?api-version=2017-12-01" vmInstanceMetadataURL = "http://169.254.169.254/metadata/instance?api-version=2017-12-01"
resourceIDTemplate = "/subscriptions/%s/resourceGroups/%s/providers/Microsoft.Compute/virtualMachines/%s" resourceIDTemplate = "/subscriptions/%s/resourceGroups/%s/providers/Microsoft.Compute/virtualMachines/%s"
urlTemplate = "https://%s.monitoring.azure.com%s/metrics" resourceIDScaleSetTemplate = "/subscriptions/%s/resourceGroups/%s/providers/Microsoft.Compute/virtualMachineScaleSets/%s"
urlOverrideTemplate = "%s%s/metrics" urlTemplate = "https://%s.monitoring.azure.com%s/metrics"
maxRequestBodySize = 4000000 urlOverrideTemplate = "%s%s/metrics"
maxRequestBodySize = 4000000
) )
var sampleConfig = ` var sampleConfig = `
@ -200,31 +230,17 @@ func vmInstanceMetadata(c *http.Client) (string, string, error) {
return "", "", err return "", "", err
} }
if resp.StatusCode >= 300 || resp.StatusCode < 200 { if resp.StatusCode >= 300 || resp.StatusCode < 200 {
return "", "", fmt.Errorf("unable to fetch instance metadata: [%v] %s", resp.StatusCode, body) return "", "", fmt.Errorf("unable to fetch instance metadata: [%s] %d",
vmInstanceMetadataURL, resp.StatusCode)
} }
// VirtualMachineMetadata contains information about a VM from the metadata service var metadata virtualMachineMetadata
type VirtualMachineMetadata struct {
Compute struct {
Location string `json:"location"`
Name string `json:"name"`
ResourceGroupName string `json:"resourceGroupName"`
SubscriptionID string `json:"subscriptionId"`
} `json:"compute"`
}
var metadata VirtualMachineMetadata
if err := json.Unmarshal(body, &metadata); err != nil { if err := json.Unmarshal(body, &metadata); err != nil {
return "", "", err return "", "", err
} }
region := metadata.Compute.Location region := metadata.Compute.Location
resourceID := fmt.Sprintf( resourceID := metadata.ResourceID()
resourceIDTemplate,
metadata.Compute.SubscriptionID,
metadata.Compute.ResourceGroupName,
metadata.Compute.Name,
)
return region, resourceID, nil return region, resourceID, nil
} }