dom/telegraf
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add response time to httpjson plugin

Browse Source 
closes #475
This commit is contained in:
Thibault Cohen
2016-01-07 20:49:14 -05:00
committed by Cameron Sparr
parent 7bfb42946e
commit b44644b6bf
3 changed files with 31 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
plugins/inputs/httpjson/httpjson_test.go
View File

@@ -14,7 +14,7 @@ import (
const validJSON = `
{
"parent": {
"child": 3,
"child": 3.0,
"ignored_child": "hi"
},
"ignored_null": null,
@@ -126,10 +126,16 @@ func TestHttpJson200(t *testing.T) {
var acc testutil.Accumulator
err := service.Gather(&acc)
require.NoError(t, err)
assert.Equal(t, 10, acc.NFields())
assert.Equal(t, 12, acc.NFields())
// Set responsetime
for _, p := range acc.Points {
p.Fields["response_time"] = 1.0
}
for _, srv := range service.Servers {
tags := map[string]string{"server": srv}
mname := "httpjson_" + service.Name
expectedFields["response_time"] = 1.0
acc.AssertContainsTaggedFields(t, mname, expectedFields, tags)
}
}
@@ -188,11 +194,15 @@ func TestHttpJson200Tags(t *testing.T) {
if service.Name == "other_webapp" {
var acc testutil.Accumulator
err := service.Gather(&acc)
// Set responsetime
for _, p := range acc.Points {
p.Fields["response_time"] = 1.0
}
require.NoError(t, err)
assert.Equal(t, 2, acc.NFields())
assert.Equal(t, 4, acc.NFields())
for _, srv := range service.Servers {
tags := map[string]string{"server": srv, "role": "master", "build": "123"}
fields := map[string]interface{}{"value": float64(15)}
fields := map[string]interface{}{"value": float64(15), "response_time": float64(1)}
mname := "httpjson_" + service.Name
acc.AssertContainsTaggedFields(t, mname, fields, tags)
}