From c8d2ba2bc8bffffc04b30223c5b84d0c53538fd1 Mon Sep 17 00:00:00 2001 From: Daniel Nelson Date: Mon, 16 Apr 2018 18:52:52 -0700 Subject: [PATCH] Remove RateLimiter tests due to race conditions These tests are fundamentally racy, removing to improve reliability of test cases. --- internal/limiter/limiter_test.go | 54 -------------------------------- 1 file changed, 54 deletions(-) delete mode 100644 internal/limiter/limiter_test.go diff --git a/internal/limiter/limiter_test.go b/internal/limiter/limiter_test.go deleted file mode 100644 index 83c9d86f1..000000000 --- a/internal/limiter/limiter_test.go +++ /dev/null @@ -1,54 +0,0 @@ -package limiter - -import ( - "testing" - "time" - - "github.com/stretchr/testify/assert" -) - -func TestRateLimiter(t *testing.T) { - r := NewRateLimiter(5, time.Second) - ticker := time.NewTicker(time.Millisecond * 75) - - // test that we can only get 5 receives from the rate limiter - counter := 0 -outer: - for { - select { - case <-r.C: - counter++ - case <-ticker.C: - break outer - } - } - - assert.Equal(t, 5, counter) - r.Stop() - // verify that the Stop function closes the channel. - _, ok := <-r.C - assert.False(t, ok) -} - -func TestRateLimiterMultipleIterations(t *testing.T) { - r := NewRateLimiter(5, time.Millisecond*50) - ticker := time.NewTicker(time.Millisecond * 250) - - // test that we can get 15 receives from the rate limiter - counter := 0 -outer: - for { - select { - case <-ticker.C: - break outer - case <-r.C: - counter++ - } - } - - assert.True(t, counter > 10) - r.Stop() - // verify that the Stop function closes the channel. - _, ok := <-r.C - assert.False(t, ok) -}