shim improvements for docs, clean quit, and slow readers (#7452)

This commit is contained in:
Steven Soroka
2020-05-05 10:14:57 -04:00
committed by GitHub
parent 8ee12d07a1
commit cc927357a4
12 changed files with 159 additions and 104 deletions

View File

@@ -3,11 +3,20 @@
package shim
import (
"context"
"os"
"os/signal"
"syscall"
)
func listenForCollectMetricsSignals(collectMetricsPrompt chan os.Signal) {
func listenForCollectMetricsSignals(ctx context.Context, collectMetricsPrompt chan os.Signal) {
signal.Notify(collectMetricsPrompt, syscall.SIGHUP)
go func() {
select {
case <-ctx.Done():
// context done. stop to signals to avoid pushing messages to a closed channel
signal.Stop(collectMetricsPrompt)
}
}()
}