dom/telegraf
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Default SNMP parameter changes

Browse Source 
max-repetitions = 10 is the default of net-snmp utils according to
http://net-snmp.sourceforge.net/docs/man/snmpbulkwalk.html

retries = 3 is the default of gosnmp:
https://godoc.org/github.com/soniah/gosnmp#pkg-variables

Could deal with some parts of the performance issues reported
by #1665
This commit is contained in:
Cameron Sparr
2016-09-26 15:12:28 +01:00
parent 055ef168ae
commit e7e39df6a0
3 changed files with 22 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/inputs/snmp/snmp_test.go
View File

@@ -91,7 +91,8 @@ func TestSampleConfig(t *testing.T) {
Timeout: internal.Duration{Duration: 5 * time.Second},
Version: 2,
Community: "public",
MaxRepetitions: 50,
MaxRepetitions: 10,
Retries: 3,
Name: "system",
Fields: []Field{
@@ -147,7 +148,6 @@ func TestFieldInit(t *testing.T) {
}
assert.Equal(t, txl.expectedOid, f.Oid, "inputOid='%s' inputName='%s' inputConversion='%s'", txl.inputOid, txl.inputName, txl.inputConversion)
assert.Equal(t, txl.expectedName, f.Name, "inputOid='%s' inputName='%s' inputConversion='%s'", txl.inputOid, txl.inputName, txl.inputConversion)
assert.Equal(t, txl.expectedConversion, f.Conversion, "inputOid='%s' inputName='%s' inputConversion='%s'", txl.inputOid, txl.inputName, txl.inputConversion)
}
}