Fix duplicate tags when overriding tag (#4056)
This commit is contained in:
parent
648d7ae922
commit
ee9a2f73a1
|
@ -123,6 +123,7 @@ func (m *metric) AddTag(key, value string) {
|
||||||
|
|
||||||
if key == tag.Key {
|
if key == tag.Key {
|
||||||
tag.Value = value
|
tag.Value = value
|
||||||
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
m.tags = append(m.tags, nil)
|
m.tags = append(m.tags, nil)
|
||||||
|
|
|
@ -63,6 +63,7 @@ func TestAddTagOverwrites(t *testing.T) {
|
||||||
value, ok := m.GetTag("host")
|
value, ok := m.GetTag("host")
|
||||||
require.True(t, ok)
|
require.True(t, ok)
|
||||||
require.Equal(t, "example.org", value)
|
require.Equal(t, "example.org", value)
|
||||||
|
require.Equal(t, 1, len(m.TagList()))
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestRemoveTagNoEffectOnMissingTags(t *testing.T) {
|
func TestRemoveTagNoEffectOnMissingTags(t *testing.T) {
|
||||||
|
|
Loading…
Reference in New Issue