Enforce stat prefixing at the accumulator layer

This commit is contained in:
Evan Phoenix
2015-05-18 12:15:15 -07:00
parent 34e87e7026
commit f1e1204374
10 changed files with 439 additions and 314 deletions

View File

@@ -22,36 +22,36 @@ type Redis struct {
}
var Tracking = map[string]string{
"uptime_in_seconds": "redis_uptime",
"connected_clients": "redis_clients",
"used_memory": "redis_used_memory",
"used_memory_rss": "redis_used_memory_rss",
"used_memory_peak": "redis_used_memory_peak",
"used_memory_lua": "redis_used_memory_lua",
"rdb_changes_since_last_save": "redis_rdb_changes_since_last_save",
"total_connections_received": "redis_total_connections_received",
"total_commands_processed": "redis_total_commands_processed",
"instantaneous_ops_per_sec": "redis_instantaneous_ops_per_sec",
"sync_full": "redis_sync_full",
"sync_partial_ok": "redis_sync_partial_ok",
"sync_partial_err": "redis_sync_partial_err",
"expired_keys": "redis_expired_keys",
"evicted_keys": "redis_evicted_keys",
"keyspace_hits": "redis_keyspace_hits",
"keyspace_misses": "redis_keyspace_misses",
"pubsub_channels": "redis_pubsub_channels",
"pubsub_patterns": "redis_pubsub_patterns",
"latest_fork_usec": "redis_latest_fork_usec",
"connected_slaves": "redis_connected_slaves",
"master_repl_offset": "redis_master_repl_offset",
"repl_backlog_active": "redis_repl_backlog_active",
"repl_backlog_size": "redis_repl_backlog_size",
"repl_backlog_histlen": "redis_repl_backlog_histlen",
"mem_fragmentation_ratio": "redis_mem_fragmentation_ratio",
"used_cpu_sys": "redis_used_cpu_sys",
"used_cpu_user": "redis_used_cpu_user",
"used_cpu_sys_children": "redis_used_cpu_sys_children",
"used_cpu_user_children": "redis_used_cpu_user_children",
"uptime_in_seconds": "uptime",
"connected_clients": "clients",
"used_memory": "used_memory",
"used_memory_rss": "used_memory_rss",
"used_memory_peak": "used_memory_peak",
"used_memory_lua": "used_memory_lua",
"rdb_changes_since_last_save": "rdb_changes_since_last_save",
"total_connections_received": "total_connections_received",
"total_commands_processed": "total_commands_processed",
"instantaneous_ops_per_sec": "instantaneous_ops_per_sec",
"sync_full": "sync_full",
"sync_partial_ok": "sync_partial_ok",
"sync_partial_err": "sync_partial_err",
"expired_keys": "expired_keys",
"evicted_keys": "evicted_keys",
"keyspace_hits": "keyspace_hits",
"keyspace_misses": "keyspace_misses",
"pubsub_channels": "pubsub_channels",
"pubsub_patterns": "pubsub_patterns",
"latest_fork_usec": "latest_fork_usec",
"connected_slaves": "connected_slaves",
"master_repl_offset": "master_repl_offset",
"repl_backlog_active": "repl_backlog_active",
"repl_backlog_size": "repl_backlog_size",
"repl_backlog_histlen": "repl_backlog_histlen",
"mem_fragmentation_ratio": "mem_fragmentation_ratio",
"used_cpu_sys": "used_cpu_sys",
"used_cpu_user": "used_cpu_user",
"used_cpu_sys_children": "used_cpu_sys_children",
"used_cpu_user_children": "used_cpu_user_children",
}
var ErrProtocolError = errors.New("redis protocol error")

View File

@@ -55,31 +55,31 @@ func TestRedisGeneratesMetrics(t *testing.T) {
name string
value uint64
}{
{"redis_uptime", 238},
{"redis_clients", 1},
{"redis_used_memory", 1003936},
{"redis_used_memory_rss", 811008},
{"redis_used_memory_peak", 1003936},
{"redis_used_memory_lua", 33792},
{"redis_rdb_changes_since_last_save", 0},
{"redis_total_connections_received", 2},
{"redis_total_commands_processed", 1},
{"redis_instantaneous_ops_per_sec", 0},
{"redis_sync_full", 0},
{"redis_sync_partial_ok", 0},
{"redis_sync_partial_err", 0},
{"redis_expired_keys", 0},
{"redis_evicted_keys", 0},
{"redis_keyspace_hits", 0},
{"redis_keyspace_misses", 0},
{"redis_pubsub_channels", 0},
{"redis_pubsub_patterns", 0},
{"redis_latest_fork_usec", 0},
{"redis_connected_slaves", 0},
{"redis_master_repl_offset", 0},
{"redis_repl_backlog_active", 0},
{"redis_repl_backlog_size", 1048576},
{"redis_repl_backlog_histlen", 0},
{"uptime", 238},
{"clients", 1},
{"used_memory", 1003936},
{"used_memory_rss", 811008},
{"used_memory_peak", 1003936},
{"used_memory_lua", 33792},
{"rdb_changes_since_last_save", 0},
{"total_connections_received", 2},
{"total_commands_processed", 1},
{"instantaneous_ops_per_sec", 0},
{"sync_full", 0},
{"sync_partial_ok", 0},
{"sync_partial_err", 0},
{"expired_keys", 0},
{"evicted_keys", 0},
{"keyspace_hits", 0},
{"keyspace_misses", 0},
{"pubsub_channels", 0},
{"pubsub_patterns", 0},
{"latest_fork_usec", 0},
{"connected_slaves", 0},
{"master_repl_offset", 0},
{"repl_backlog_active", 0},
{"repl_backlog_size", 1048576},
{"repl_backlog_histlen", 0},
}
for _, c := range checkInt {
@@ -90,11 +90,11 @@ func TestRedisGeneratesMetrics(t *testing.T) {
name string
value float64
}{
{"redis_mem_fragmentation_ratio", 0.81},
{"redis_used_cpu_sys", 0.14},
{"redis_used_cpu_user", 0.05},
{"redis_used_cpu_sys_children", 0.00},
{"redis_used_cpu_user_children", 0.00},
{"mem_fragmentation_ratio", 0.81},
{"used_cpu_sys", 0.14},
{"used_cpu_user", 0.05},
{"used_cpu_sys_children", 0.00},
{"used_cpu_user_children", 0.00},
}
for _, c := range checkFloat {
@@ -146,31 +146,31 @@ func TestRedisCanPullStatsFromMultipleServers(t *testing.T) {
name string
value uint64
}{
{"redis_uptime", 238},
{"redis_clients", 1},
{"redis_used_memory", 1003936},
{"redis_used_memory_rss", 811008},
{"redis_used_memory_peak", 1003936},
{"redis_used_memory_lua", 33792},
{"redis_rdb_changes_since_last_save", 0},
{"redis_total_connections_received", 2},
{"redis_total_commands_processed", 1},
{"redis_instantaneous_ops_per_sec", 0},
{"redis_sync_full", 0},
{"redis_sync_partial_ok", 0},
{"redis_sync_partial_err", 0},
{"redis_expired_keys", 0},
{"redis_evicted_keys", 0},
{"redis_keyspace_hits", 0},
{"redis_keyspace_misses", 0},
{"redis_pubsub_channels", 0},
{"redis_pubsub_patterns", 0},
{"redis_latest_fork_usec", 0},
{"redis_connected_slaves", 0},
{"redis_master_repl_offset", 0},
{"redis_repl_backlog_active", 0},
{"redis_repl_backlog_size", 1048576},
{"redis_repl_backlog_histlen", 0},
{"uptime", 238},
{"clients", 1},
{"used_memory", 1003936},
{"used_memory_rss", 811008},
{"used_memory_peak", 1003936},
{"used_memory_lua", 33792},
{"rdb_changes_since_last_save", 0},
{"total_connections_received", 2},
{"total_commands_processed", 1},
{"instantaneous_ops_per_sec", 0},
{"sync_full", 0},
{"sync_partial_ok", 0},
{"sync_partial_err", 0},
{"expired_keys", 0},
{"evicted_keys", 0},
{"keyspace_hits", 0},
{"keyspace_misses", 0},
{"pubsub_channels", 0},
{"pubsub_patterns", 0},
{"latest_fork_usec", 0},
{"connected_slaves", 0},
{"master_repl_offset", 0},
{"repl_backlog_active", 0},
{"repl_backlog_size", 1048576},
{"repl_backlog_histlen", 0},
}
for _, c := range checkInt {
@@ -181,11 +181,11 @@ func TestRedisCanPullStatsFromMultipleServers(t *testing.T) {
name string
value float64
}{
{"redis_mem_fragmentation_ratio", 0.81},
{"redis_used_cpu_sys", 0.14},
{"redis_used_cpu_user", 0.05},
{"redis_used_cpu_sys_children", 0.00},
{"redis_used_cpu_user_children", 0.00},
{"mem_fragmentation_ratio", 0.81},
{"used_cpu_sys", 0.14},
{"used_cpu_user", 0.05},
{"used_cpu_sys_children", 0.00},
{"used_cpu_user_children", 0.00},
}
for _, c := range checkFloat {