Fix multiple redis server bug, do not cache the TCP connections

Fixes #178

CHANGELOG.md

@@ -11,6 +11,7 @@ will still be backwards compatible if only `url` is specified.
 ### Bugfixes
 - [#170](https://github.com/influxdb/telegraf/issues/170): Systemd support
 - [#175](https://github.com/influxdb/telegraf/issues/175): Set write precision before gathering metrics
+- [#178](https://github.com/influxdb/telegraf/issues/178): redis plugin, multiple server thread hang bug
 
 ## v0.1.8 [2015-09-04]
 

plugins/redis/redis.go

@@ -15,9 +15,6 @@ import (
 
 type Redis struct {
 	Servers []string
-
-	c   net.Conn
-	buf []byte
 }
 
 var sampleConfig = `
@@ -112,8 +109,6 @@ func (r *Redis) Gather(acc plugins.Accumulator) error {
 const defaultPort = "6379"
 
 func (r *Redis) gatherServer(addr *url.URL, acc plugins.Accumulator) error {
-	if r.c == nil {
-
 	_, _, err := net.SplitHostPort(addr.Host)
 	if err != nil {
 		addr.Host = addr.Host + ":" + defaultPort
@@ -123,6 +118,7 @@ func (r *Redis) gatherServer(addr *url.URL, acc plugins.Accumulator) error {
 	if err != nil {
 		return fmt.Errorf("Unable to connect to redis server '%s': %s", addr.Host, err)
 	}
+	defer c.Close()
 
 	if addr.User != nil {
 		pwd, set := addr.User.Password()
@@ -141,12 +137,9 @@ func (r *Redis) gatherServer(addr *url.URL, acc plugins.Accumulator) error {
 		}
 	}
 
-		r.c = c
-	}
+	c.Write([]byte("info\r\n"))
 
-	r.c.Write([]byte("info\r\n"))
-
-	rdr := bufio.NewReader(r.c)
+	rdr := bufio.NewReader(c)
 
 	line, err := rdr.ReadString('\n')
 	if err != nil {