dom
/
telegraf
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
telegraf/plugins/inputs
History
Daniel Nelson 9ba023fd67
[inputs/diskio] Fix how major and minor identifiers of block devices are read. (#5566) 
* Fix how major and minor identifiers of block devices are read.

The current implementation assure that the major and the minor are
coded on one byte. But they are not:

```
brw-rw----  1 root disk    252, 290 Feb 25 11:36 dm-290
```

290 as minor in this example is over 1 byte.

So after wondering why all my devices iops weren't correctly stored,
I found out that several points were added for some disks. For `dm-290`
it was overriding `252:34`, instead of getting udev stats for `252:290`.

The solution is here:
https://sites.uclouvain.be/SystInfo/usr/include/sys/sysmacros.h.html

The implementation is directly taken from this, fixing my bug.

* Use unix.Major/unix.Minor instead of custom implementation

* [diskio] Force type of stat.Rdev uint64 for mipsle compatibility

For most platforms, stat.Rdev is already a uint64 so this is without any effect
for linux,mipsle, unix.Stat_t.Rdev is a uint32, but the way to compute major and minor doesn't change, casting the uint32 has no impact either
 		2019-03-22 14:03:48 -07:00
..
activemq Add configurable timeout to varnish input (#5214) 2019-01-03 11:33:04 -08:00
aerospike Support uint fields in aerospike input (#4851) 2018-10-12 14:37:30 -07:00
all Add cloud pubsub push input plugin (#5442) 2019-02-26 18:25:42 -08:00
amqp_consumer Ack delivery if it is unparseable in amqp_consumer input (#5286) 2019-01-15 11:48:36 -08:00
apache Fix waitgroup deadlock if url is incorrect in apache input (#4176) 2018-05-21 10:43:02 -07:00
aurora Add aurora input plugin (#4158) 2018-05-21 11:59:39 -07:00
bcache Enable gofmt code simplification (#4887) 2018-10-19 13:32:54 -07:00
beanstalkd Add Beanstalkd input plugin (#4272) 2018-09-10 11:51:03 -07:00
bond Update bond input description 2017-12-14 16:03:29 -08:00
burrow Fix burrow_group.offset calculation for Burrow plugin (#4584) 2018-08-23 13:30:59 -07:00
cassandra Fix links to jolokia example configs 2018-04-24 12:46:40 -07:00
ceph Add ceph_health metrics to ceph input (#5482) 2019-02-25 16:02:30 -08:00
cgroup Enable gofmt code simplification (#4887) 2018-10-19 13:32:54 -07:00
chrony Enable chrony for all platforms (#3152) 2017-08-22 11:49:51 -07:00
cloud_pubsub Add Base64-encoding/decoding for Google Cloud PubSub plugins (#5543) 2019-03-06 17:34:47 -08:00
cloud_pubsub_push Add cloud pubsub push input plugin (#5442) 2019-02-26 18:25:42 -08:00
cloudwatch Enable gofmt code simplification (#4887) 2018-10-19 13:32:54 -07:00
conntrack Use random name for test sockets to avoid intermittent failure 2018-06-03 20:19:39 -07:00
consul Don't add empty healthcheck tags to consul input (#5575) 2019-03-19 13:39:42 -07:00
couchbase Remove credentials from cluster tag in couchbase (#5313) 2019-01-18 11:43:24 -08:00
couchdb Add support for basic auth to couchdb input (#5160) 2018-12-19 12:59:27 -08:00
cpu Enable gofmt code simplification (#4887) 2018-10-19 13:32:54 -07:00
dcos Enable gofmt code simplification (#4887) 2018-10-19 13:32:54 -07:00
disk Document using posix acl in disk input 2018-12-20 12:12:25 -08:00
diskio [diskio] Force type of stat.Rdev uint64 for mipsle compatibility 2019-03-21 12:00:20 +01:00
disque
…
dmcache Fix dmcache tests with 32bit int 2017-09-26 15:25:57 -07:00
dns_query Add rcode tag and field to dns_query input (#5417) 2019-02-12 17:57:20 -08:00
docker Fix panic in docker input with bad endpoint (#5226) 2019-01-03 15:57:39 -08:00
dovecot Update dovecot readme 2018-11-09 16:43:15 -08:00
elasticsearch Allow for force gathering ES cluster stats (#4345) 2018-11-19 11:53:09 -08:00
exec Fix grammar in exec input readme (#4740) 2018-09-24 13:41:12 -07:00
fail2ban Update sudo config recommendation (#5337) 2019-01-24 10:54:25 -08:00
fibaro Add energy and power field and device id tag to fibaro input (#4343) 2018-07-02 11:57:05 -07:00
file Use godirwalk in globpath (#5145) 2018-12-18 14:23:25 -08:00
filecount Log permission error and ignore in filecount input (#5483) 2019-02-26 14:03:25 -08:00
filestat Use godirwalk in globpath (#5145) 2018-12-18 14:23:25 -08:00
fluentd Fix grammar and typos in fluentd README.md (#5127) 2018-12-10 15:24:11 -08:00
graylog Fix typo in graylog documentation (#5253) 2019-01-07 11:05:22 -08:00
haproxy Use gofmt from Go 1.11 (#5259) 2019-01-07 17:14:07 -08:00
hddtemp Enable gofmt code simplification (#4887) 2018-10-19 13:32:54 -07:00
http Add support for sending a request body to http input (#5074) 2018-12-11 19:12:00 -08:00
http_listener_v2 Add ability to specify bytes options as strings with units (KB, MiB, ...) (#4852) 2018-10-19 11:17:18 -07:00
http_response Document response_string_match field in http_response (#5251) 2019-01-07 11:25:08 -08:00
httpjson Enable gofmt code simplification (#4887) 2018-10-19 13:32:54 -07:00
icinga2 Add Icinga2 input plugin (#4559) 2018-08-22 19:10:40 -07:00
influxdb Simplify testing with TLS (#4095) 2018-05-04 16:33:23 -07:00
influxdb_listener Add internal metric for line too long in influxdb_listener (#5396) 2019-02-11 12:49:06 -08:00
internal Remove outputs blocking inputs when output is slow (#4938) 2018-11-05 13:34:28 -08:00
interrupts Rename interrupts cpu_as_tags to cpu_as_tag; update readme 2018-11-30 15:00:38 -08:00
ipmi_sensor Handle panic when ipmi_sensor input gets bad input (#4937) 2018-10-30 15:05:41 -06:00
ipset Update sudo config recommendation (#5337) 2019-01-24 10:54:25 -08:00
iptables Update sudo config recommendation (#5337) 2019-01-24 10:54:25 -08:00
ipvs Update ipvs readme 2018-11-02 10:59:14 -07:00
jenkins Always send basic auth in jenkins input (#5329) 2019-01-23 14:17:57 -08:00
jolokia Enable gofmt code simplification (#4887) 2018-10-19 13:32:54 -07:00
jolokia2 Improve docs to clarify common issues (#5054) 2018-12-10 16:14:20 -08:00
jti_openconfig_telemetry Log the correct error in jti_openconfig (#4901) 2018-10-30 15:05:18 -06:00
kafka_consumer Prevent panic when marking the offset in kafka_consumer (#5118) 2018-12-10 15:55:58 -08:00
kafka_consumer_legacy Add name, time, path and string field options to JSON parser (#4351) 2018-08-22 19:26:48 -07:00
kapacitor Simplify testing with TLS (#4095) 2018-05-04 16:33:23 -07:00
kernel Moved system package inputs out to top level (#4406) 2018-07-11 16:43:49 -07:00
kernel_vmstat Moved system package inputs out to top level (#4406) 2018-07-11 16:43:49 -07:00
kibana Add Kibana input plugin (#4585) 2018-08-24 14:58:41 -07:00
kinesis_consumer Add kinesis input plugin (#5341) 2019-02-25 12:02:57 -08:00
kube_inventory Fix ClusterRole aggregation documentation in kube_inventory 2019-03-11 12:00:20 -07:00
kubernetes Support passing bearer token directly in k8s input (#5295) 2019-01-15 15:26:18 -08:00
leofs Add support for LeoFS v1.4 to leofs input (#4044) 2018-04-24 14:14:31 -07:00
linux_sysctl_fs Moved system package inputs out to top level (#4406) 2018-07-11 16:43:49 -07:00
logparser Add unique_timestamp option from grok parser to logparser grok 2019-02-26 18:05:04 -08:00
lustre2
…
mailchimp use AddError everywhere (#2372) 2017-04-24 11:13:26 -07:00
mcrouter Add input plugin for McRouter (#4077) 2018-05-01 11:58:15 -07:00
mem Add new fields to mem input readme 2018-09-11 15:15:45 -07:00
memcached Collect additional stats in memcached input (#4914) 2018-10-24 15:02:44 -07:00
mesos Enable gofmt code simplification (#4887) 2018-10-19 13:32:54 -07:00
minecraft Fix typos in comments (#3415) 2017-10-31 17:00:06 -07:00
mongodb Fix typo in mongodb field name (#5299) 2019-01-16 15:39:55 -08:00
mqtt_consumer Use gofmt from Go 1.11 (#5259) 2019-01-07 17:14:07 -08:00
multifile Update multifile plugin docs 2019-01-23 17:26:50 -08:00
mysql Use gofmt from Go 1.11 (#5259) 2019-01-07 17:14:07 -08:00
nats Do not build nats input on freebsd 2018-01-30 12:04:21 -08:00
nats_consumer Remove outputs blocking inputs when output is slow (#4938) 2018-11-05 13:34:28 -08:00
neptune_apex Remove unsupported parallel testing 2019-01-08 15:43:50 -08:00
net Enable gofmt code simplification (#4887) 2018-10-19 13:32:54 -07:00
net_response Fix incorrect option in net_response sample config 2019-03-08 14:10:55 -08:00
nginx Simplify testing with TLS (#4095) 2018-05-04 16:33:23 -07:00
nginx_plus Skip invalid urls in nginx input 2017-10-03 10:54:31 -07:00
nginx_plus_api Use gofmt from Go 1.11 (#5259) 2019-01-07 17:14:07 -08:00
nginx_upstream_check Add nginx_upstream_check input plugin (#4303) 2019-01-15 12:56:40 -08:00
nginx_vts Update to source tag in nginx_vts readme 2018-11-02 18:23:41 -07:00
nsq Update changelog and add basic nsq input readme 2018-10-22 17:55:40 -07:00
nsq_consumer Use gofmt from Go 1.11 (#5259) 2019-01-07 17:14:07 -08:00
nstat Remove error log when snmp6 directory does not exists with nstat input (#5403) (#5413) 2019-02-12 16:17:09 -08:00
ntpq Enable ntpq tests on Windows (#3972) 2018-04-04 18:35:05 -07:00
nvidia_smi Enable gofmt code simplification (#4887) 2018-10-19 13:32:54 -07:00
openldap Clarify monitoring backend provenance (#4739) 2018-09-24 12:13:36 -07:00
opensmtpd Update sudo config recommendation (#5337) 2019-01-24 10:54:25 -08:00
passenger Update passenger input documentation (#3938) 2018-03-26 19:11:08 -07:00
pf Enable gofmt code simplification (#4887) 2018-10-19 13:32:54 -07:00
pgbouncer Add pgbouncer input plugin (#3918) 2018-08-01 16:44:10 -06:00
phpfpm Fix typo in phpfpm README (#3985) 2018-04-06 16:20:36 -07:00
ping Add TTL field to ping input (#5556) 2019-03-08 14:30:38 -08:00
postfix Fix postfix input handling of multi-level queues (#4333) 2018-06-21 16:01:38 -07:00
postgresql Update changelog 2018-11-29 16:07:56 -08:00
postgresql_extensible Fix version check in postgresql_extensible (#4866) 2018-10-30 15:06:47 -06:00
powerdns Fix powerdns input test (#4554) 2018-08-14 14:35:39 -06:00
processes Moved system package inputs out to top level (#4406) 2018-07-11 16:43:49 -07:00
procstat Add running field to procstat_lookup (#5069) 2018-12-11 19:11:33 -08:00
prometheus Collect from newly discovered/launched pods (#5293) 2019-01-16 15:49:24 -08:00
puppetagent Fix telegraf example arguments (#2788) 2017-05-12 15:22:29 -07:00
rabbitmq Improvement of RabbitMQ plugin #3025 #3252 2018-06-19 13:12:23 +04:00
raindrops Fix telegraf example arguments (#2788) 2017-05-12 15:22:29 -07:00
redis Improve docs to clarify common issues (#5054) 2018-12-10 16:14:20 -08:00
rethinkdb Add support for RethinkDB 1.0 handshake protocol (#2963) 2017-06-26 14:29:48 -07:00
riak Fix telegraf example arguments (#2788) 2017-05-12 15:22:29 -07:00
salesforce Add salesforce input plugin (#3075) 2017-08-08 11:48:01 -07:00
sensors Add timeout option to sensors input (#4162) 2018-05-22 13:59:59 -07:00
smart Update sudo config recommendation (#5337) 2019-01-24 10:54:25 -08:00
snmp Add command logging to snmp input at debug level (#5474) 2019-02-25 11:04:34 -08:00
snmp_legacy
…
socket_listener Return any errors when creating tls config (#5541) 2019-03-06 17:37:44 -08:00
solr Add support for solr 7 to the solr input (#4271) 2018-06-12 13:56:13 -07:00
sqlserver Disable results by row in azuredb query (#5467) 2019-02-25 10:54:19 -08:00
stackdriver Add stackdriver input plugin (#5406) 2019-02-20 13:23:59 -08:00
statsd Enable gofmt code simplification (#4887) 2018-10-19 13:32:54 -07:00
swap Add more detailed descriptions for fields in swap input (#4763) 2018-10-18 12:59:03 -07:00
syslog Return new Syslog instance for each plugin (#5372) 2019-02-04 11:21:16 -08:00
sysstat Add parameter to force the interval of gather for sysstat (#4068) 2018-04-25 18:59:42 -07:00
system Minimize call to collect uptime in system input (#5592) 2019-03-18 11:07:44 -07:00
tail Use godirwalk in globpath (#5145) 2018-12-18 14:23:25 -08:00
tcp_listener Add name, time, path and string field options to JSON parser (#4351) 2018-08-22 19:26:48 -07:00
teamspeak Add Teamspeak 3 input plugin (#3315) 2017-11-01 13:27:59 -07:00
temp Clarify platform support for temp input (#4756) 2018-09-26 19:05:55 -07:00
tengine Update tengine docs 2018-06-07 12:35:46 -07:00
tomcat Simplify testing with TLS (#4095) 2018-05-04 16:33:23 -07:00
trig
…
twemproxy
…
udp_listener Use gofmt from Go 1.11 (#5259) 2019-01-07 17:14:07 -08:00
unbound Update sudo config recommendation (#5337) 2019-01-24 10:54:25 -08:00
varnish Update sudo config recommendation (#5337) 2019-01-24 10:54:25 -08:00
vsphere Remove trailing whitespace and wordwrap readme in vsphere 2019-03-11 12:31:48 -07:00
webhooks Fix links and add config to webhook readme (#5558) 2019-03-08 11:25:20 -08:00
win_perf_counters Add PDH_NO_DATA to known counter error codes in win_perf_counters (#5182) 2018-12-26 14:51:31 -08:00
win_services Log access denied opening a service at debug level (#4674) 2018-09-11 16:04:16 -07:00
wireless Log warning when wireless plugin is used on unsupported platform (#4986) 2018-11-15 15:45:56 -08:00
x509_cert Continue checking cert from other sources if error occurs (#5381) 2019-02-05 17:38:04 -08:00
zfs Use explicit zpool properties to fix parse error on FreeBSD 11.2 (#4510) 2018-08-07 11:07:07 -07:00
zipkin Enable gofmt code simplification (#4887) 2018-10-19 13:32:54 -07:00
zookeeper Use 'localhost' as default 'server' tag in zookeeper input (#4387) 2018-07-05 14:37:13 -07:00
EXAMPLE_README.md Add troubleshooting section to disk input README 2018-11-14 11:40:11 -08:00
mock_Plugin.go
…
registry.go
…