2016-09-18 00:10:46 +00:00
|
|
|
//go:generate go run -tags generate snmp_mocks_generate.go
|
2016-08-22 15:37:53 +00:00
|
|
|
package snmp
|
|
|
|
|
|
|
|
import (
|
|
|
|
"fmt"
|
|
|
|
"net"
|
2016-12-12 13:30:07 +00:00
|
|
|
"os/exec"
|
2016-08-22 15:37:53 +00:00
|
|
|
"sync"
|
|
|
|
"testing"
|
|
|
|
"time"
|
|
|
|
|
|
|
|
"github.com/influxdata/telegraf/internal"
|
|
|
|
"github.com/influxdata/telegraf/testutil"
|
|
|
|
"github.com/influxdata/toml"
|
|
|
|
"github.com/soniah/gosnmp"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
)
|
|
|
|
|
|
|
|
type testSNMPConnection struct {
|
|
|
|
host string
|
|
|
|
values map[string]interface{}
|
|
|
|
}
|
|
|
|
|
|
|
|
func (tsc *testSNMPConnection) Host() string {
|
|
|
|
return tsc.host
|
|
|
|
}
|
|
|
|
|
|
|
|
func (tsc *testSNMPConnection) Get(oids []string) (*gosnmp.SnmpPacket, error) {
|
|
|
|
sp := &gosnmp.SnmpPacket{}
|
|
|
|
for _, oid := range oids {
|
|
|
|
v, ok := tsc.values[oid]
|
|
|
|
if !ok {
|
|
|
|
sp.Variables = append(sp.Variables, gosnmp.SnmpPDU{
|
|
|
|
Name: oid,
|
|
|
|
Type: gosnmp.NoSuchObject,
|
|
|
|
})
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
sp.Variables = append(sp.Variables, gosnmp.SnmpPDU{
|
|
|
|
Name: oid,
|
|
|
|
Value: v,
|
|
|
|
})
|
|
|
|
}
|
|
|
|
return sp, nil
|
|
|
|
}
|
|
|
|
func (tsc *testSNMPConnection) Walk(oid string, wf gosnmp.WalkFunc) error {
|
|
|
|
for void, v := range tsc.values {
|
|
|
|
if void == oid || (len(void) > len(oid) && void[:len(oid)+1] == oid+".") {
|
|
|
|
if err := wf(gosnmp.SnmpPDU{
|
|
|
|
Name: void,
|
|
|
|
Value: v,
|
|
|
|
}); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
var tsc = &testSNMPConnection{
|
|
|
|
host: "tsc",
|
|
|
|
values: map[string]interface{}{
|
2016-09-18 03:08:00 +00:00
|
|
|
".1.0.0.0.1.1.0": "foo",
|
|
|
|
".1.0.0.0.1.1.1": []byte("bar"),
|
2016-10-04 14:46:01 +00:00
|
|
|
".1.0.0.0.1.1.2": []byte(""),
|
2016-09-18 03:08:00 +00:00
|
|
|
".1.0.0.0.1.102": "bad",
|
|
|
|
".1.0.0.0.1.2.0": 1,
|
|
|
|
".1.0.0.0.1.2.1": 2,
|
2016-10-04 14:46:01 +00:00
|
|
|
".1.0.0.0.1.2.2": 0,
|
2016-09-18 03:08:00 +00:00
|
|
|
".1.0.0.0.1.3.0": "0.123",
|
|
|
|
".1.0.0.0.1.3.1": "0.456",
|
2016-10-04 14:46:01 +00:00
|
|
|
".1.0.0.0.1.3.2": "0.000",
|
|
|
|
".1.0.0.0.1.3.3": "9.999",
|
2018-05-30 02:03:37 +00:00
|
|
|
".1.0.0.0.1.5.0": 123456,
|
2016-09-18 03:08:00 +00:00
|
|
|
".1.0.0.1.1": "baz",
|
|
|
|
".1.0.0.1.2": 234,
|
|
|
|
".1.0.0.1.3": []byte("byte slice"),
|
|
|
|
".1.0.0.2.1.5.0.9.9": 11,
|
|
|
|
".1.0.0.2.1.5.1.9.9": 22,
|
2016-08-22 15:37:53 +00:00
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestSampleConfig(t *testing.T) {
|
|
|
|
conf := struct {
|
|
|
|
Inputs struct {
|
|
|
|
Snmp []*Snmp
|
|
|
|
}
|
|
|
|
}{}
|
|
|
|
err := toml.Unmarshal([]byte("[[inputs.snmp]]\n"+(*Snmp)(nil).SampleConfig()), &conf)
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
|
|
|
s := Snmp{
|
|
|
|
Agents: []string{"127.0.0.1:161"},
|
|
|
|
Timeout: internal.Duration{Duration: 5 * time.Second},
|
|
|
|
Version: 2,
|
|
|
|
Community: "public",
|
2016-09-26 14:12:28 +00:00
|
|
|
MaxRepetitions: 10,
|
|
|
|
Retries: 3,
|
2016-08-22 15:37:53 +00:00
|
|
|
|
|
|
|
Name: "system",
|
|
|
|
Fields: []Field{
|
|
|
|
{Name: "hostname", Oid: ".1.0.0.1.1"},
|
|
|
|
{Name: "uptime", Oid: ".1.0.0.1.2"},
|
|
|
|
{Name: "load", Oid: ".1.0.0.1.3"},
|
|
|
|
{Oid: "HOST-RESOURCES-MIB::hrMemorySize"},
|
|
|
|
},
|
|
|
|
Tables: []Table{
|
|
|
|
{
|
|
|
|
Name: "remote_servers",
|
|
|
|
InheritTags: []string{"hostname"},
|
|
|
|
Fields: []Field{
|
|
|
|
{Name: "server", Oid: ".1.0.0.0.1.0", IsTag: true},
|
|
|
|
{Name: "connections", Oid: ".1.0.0.0.1.1"},
|
|
|
|
{Name: "latency", Oid: ".1.0.0.0.1.2"},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
{
|
|
|
|
Oid: "HOST-RESOURCES-MIB::hrNetworkTable",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
2017-10-25 22:28:55 +00:00
|
|
|
assert.Equal(t, &s, conf.Inputs.Snmp[0])
|
2016-08-22 15:37:53 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
func TestFieldInit(t *testing.T) {
|
|
|
|
translations := []struct {
|
2016-09-18 01:12:07 +00:00
|
|
|
inputOid string
|
|
|
|
inputName string
|
|
|
|
inputConversion string
|
|
|
|
expectedOid string
|
|
|
|
expectedName string
|
|
|
|
expectedConversion string
|
2016-08-22 15:37:53 +00:00
|
|
|
}{
|
2016-10-04 15:22:15 +00:00
|
|
|
{".1.2.3", "foo", "", ".1.2.3", "foo", ""},
|
|
|
|
{".iso.2.3", "foo", "", ".1.2.3", "foo", ""},
|
2016-09-18 01:12:07 +00:00
|
|
|
{".1.0.0.0.1.1", "", "", ".1.0.0.0.1.1", "server", ""},
|
|
|
|
{".1.0.0.0.1.1.0", "", "", ".1.0.0.0.1.1.0", "server.0", ""},
|
|
|
|
{".999", "", "", ".999", ".999", ""},
|
|
|
|
{"TEST::server", "", "", ".1.0.0.0.1.1", "server", ""},
|
|
|
|
{"TEST::server.0", "", "", ".1.0.0.0.1.1.0", "server.0", ""},
|
|
|
|
{"TEST::server", "foo", "", ".1.0.0.0.1.1", "foo", ""},
|
|
|
|
{"IF-MIB::ifPhysAddress.1", "", "", ".1.3.6.1.2.1.2.2.1.6.1", "ifPhysAddress.1", "hwaddr"},
|
|
|
|
{"IF-MIB::ifPhysAddress.1", "", "none", ".1.3.6.1.2.1.2.2.1.6.1", "ifPhysAddress.1", "none"},
|
|
|
|
{"BRIDGE-MIB::dot1dTpFdbAddress.1", "", "", ".1.3.6.1.2.1.17.4.3.1.1.1", "dot1dTpFdbAddress.1", "hwaddr"},
|
|
|
|
{"TCP-MIB::tcpConnectionLocalAddress.1", "", "", ".1.3.6.1.2.1.6.19.1.2.1", "tcpConnectionLocalAddress.1", "ipaddr"},
|
2016-08-22 15:37:53 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
for _, txl := range translations {
|
2016-09-18 01:12:07 +00:00
|
|
|
f := Field{Oid: txl.inputOid, Name: txl.inputName, Conversion: txl.inputConversion}
|
2016-08-22 15:37:53 +00:00
|
|
|
err := f.init()
|
|
|
|
if !assert.NoError(t, err, "inputOid='%s' inputName='%s'", txl.inputOid, txl.inputName) {
|
|
|
|
continue
|
|
|
|
}
|
2016-09-18 01:12:07 +00:00
|
|
|
assert.Equal(t, txl.expectedOid, f.Oid, "inputOid='%s' inputName='%s' inputConversion='%s'", txl.inputOid, txl.inputName, txl.inputConversion)
|
|
|
|
assert.Equal(t, txl.expectedName, f.Name, "inputOid='%s' inputName='%s' inputConversion='%s'", txl.inputOid, txl.inputName, txl.inputConversion)
|
2016-08-22 15:37:53 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestTableInit(t *testing.T) {
|
|
|
|
tbl := Table{
|
2018-05-30 02:03:37 +00:00
|
|
|
Oid: ".1.0.0.0",
|
|
|
|
Fields: []Field{
|
|
|
|
{Oid: ".999", Name: "foo"},
|
|
|
|
{Oid: "TEST::description", Name: "description", IsTag: true},
|
|
|
|
},
|
2016-08-22 15:37:53 +00:00
|
|
|
}
|
|
|
|
err := tbl.init()
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
assert.Equal(t, "testTable", tbl.Name)
|
|
|
|
|
2018-05-30 02:03:37 +00:00
|
|
|
assert.Len(t, tbl.Fields, 5)
|
2016-08-22 15:37:53 +00:00
|
|
|
assert.Contains(t, tbl.Fields, Field{Oid: ".999", Name: "foo", initialized: true})
|
|
|
|
assert.Contains(t, tbl.Fields, Field{Oid: ".1.0.0.0.1.1", Name: "server", IsTag: true, initialized: true})
|
|
|
|
assert.Contains(t, tbl.Fields, Field{Oid: ".1.0.0.0.1.2", Name: "connections", initialized: true})
|
|
|
|
assert.Contains(t, tbl.Fields, Field{Oid: ".1.0.0.0.1.3", Name: "latency", initialized: true})
|
2018-05-30 02:03:37 +00:00
|
|
|
assert.Contains(t, tbl.Fields, Field{Oid: ".1.0.0.0.1.4", Name: "description", IsTag: true, initialized: true})
|
2016-08-22 15:37:53 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
func TestSnmpInit(t *testing.T) {
|
|
|
|
s := &Snmp{
|
|
|
|
Tables: []Table{
|
|
|
|
{Oid: "TEST::testTable"},
|
|
|
|
},
|
|
|
|
Fields: []Field{
|
|
|
|
{Oid: "TEST::hostname"},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
err := s.init()
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
2018-05-30 02:03:37 +00:00
|
|
|
assert.Len(t, s.Tables[0].Fields, 4)
|
2016-08-22 15:37:53 +00:00
|
|
|
assert.Contains(t, s.Tables[0].Fields, Field{Oid: ".1.0.0.0.1.1", Name: "server", IsTag: true, initialized: true})
|
|
|
|
assert.Contains(t, s.Tables[0].Fields, Field{Oid: ".1.0.0.0.1.2", Name: "connections", initialized: true})
|
|
|
|
assert.Contains(t, s.Tables[0].Fields, Field{Oid: ".1.0.0.0.1.3", Name: "latency", initialized: true})
|
2018-05-30 02:03:37 +00:00
|
|
|
assert.Contains(t, s.Tables[0].Fields, Field{Oid: ".1.0.0.0.1.4", Name: "description", initialized: true})
|
2016-08-22 15:37:53 +00:00
|
|
|
|
|
|
|
assert.Equal(t, Field{
|
|
|
|
Oid: ".1.0.0.1.1",
|
|
|
|
Name: "hostname",
|
|
|
|
initialized: true,
|
|
|
|
}, s.Fields[0])
|
|
|
|
}
|
|
|
|
|
2016-12-12 13:30:07 +00:00
|
|
|
func TestSnmpInit_noTranslate(t *testing.T) {
|
|
|
|
// override execCommand so it returns exec.ErrNotFound
|
|
|
|
defer func(ec func(string, ...string) *exec.Cmd) { execCommand = ec }(execCommand)
|
|
|
|
execCommand = func(_ string, _ ...string) *exec.Cmd {
|
|
|
|
return exec.Command("snmptranslateExecErrNotFound")
|
|
|
|
}
|
|
|
|
|
|
|
|
s := &Snmp{
|
|
|
|
Fields: []Field{
|
|
|
|
{Oid: ".1.1.1.1", Name: "one", IsTag: true},
|
|
|
|
{Oid: ".1.1.1.2", Name: "two"},
|
|
|
|
{Oid: ".1.1.1.3"},
|
|
|
|
},
|
|
|
|
Tables: []Table{
|
|
|
|
{Fields: []Field{
|
|
|
|
{Oid: ".1.1.1.4", Name: "four", IsTag: true},
|
|
|
|
{Oid: ".1.1.1.5", Name: "five"},
|
|
|
|
{Oid: ".1.1.1.6"},
|
|
|
|
}},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
err := s.init()
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
assert.Equal(t, ".1.1.1.1", s.Fields[0].Oid)
|
|
|
|
assert.Equal(t, "one", s.Fields[0].Name)
|
|
|
|
assert.Equal(t, true, s.Fields[0].IsTag)
|
|
|
|
|
|
|
|
assert.Equal(t, ".1.1.1.2", s.Fields[1].Oid)
|
|
|
|
assert.Equal(t, "two", s.Fields[1].Name)
|
|
|
|
assert.Equal(t, false, s.Fields[1].IsTag)
|
|
|
|
|
|
|
|
assert.Equal(t, ".1.1.1.3", s.Fields[2].Oid)
|
|
|
|
assert.Equal(t, ".1.1.1.3", s.Fields[2].Name)
|
|
|
|
assert.Equal(t, false, s.Fields[2].IsTag)
|
|
|
|
|
|
|
|
assert.Equal(t, ".1.1.1.4", s.Tables[0].Fields[0].Oid)
|
|
|
|
assert.Equal(t, "four", s.Tables[0].Fields[0].Name)
|
|
|
|
assert.Equal(t, true, s.Tables[0].Fields[0].IsTag)
|
|
|
|
|
|
|
|
assert.Equal(t, ".1.1.1.5", s.Tables[0].Fields[1].Oid)
|
|
|
|
assert.Equal(t, "five", s.Tables[0].Fields[1].Name)
|
|
|
|
assert.Equal(t, false, s.Tables[0].Fields[1].IsTag)
|
|
|
|
|
|
|
|
assert.Equal(t, ".1.1.1.6", s.Tables[0].Fields[2].Oid)
|
|
|
|
assert.Equal(t, ".1.1.1.6", s.Tables[0].Fields[2].Name)
|
|
|
|
assert.Equal(t, false, s.Tables[0].Fields[2].IsTag)
|
|
|
|
}
|
|
|
|
|
2016-08-22 15:37:53 +00:00
|
|
|
func TestGetSNMPConnection_v2(t *testing.T) {
|
|
|
|
s := &Snmp{
|
2017-10-25 22:28:55 +00:00
|
|
|
Agents: []string{"1.2.3.4:567", "1.2.3.4"},
|
2016-08-22 15:37:53 +00:00
|
|
|
Timeout: internal.Duration{Duration: 3 * time.Second},
|
|
|
|
Retries: 4,
|
|
|
|
Version: 2,
|
|
|
|
Community: "foo",
|
|
|
|
}
|
2017-10-25 22:28:55 +00:00
|
|
|
err := s.init()
|
|
|
|
require.NoError(t, err)
|
2016-08-22 15:37:53 +00:00
|
|
|
|
2017-10-25 22:28:55 +00:00
|
|
|
gsc, err := s.getConnection(0)
|
2016-08-22 15:37:53 +00:00
|
|
|
require.NoError(t, err)
|
|
|
|
gs := gsc.(gosnmpWrapper)
|
|
|
|
assert.Equal(t, "1.2.3.4", gs.Target)
|
|
|
|
assert.EqualValues(t, 567, gs.Port)
|
|
|
|
assert.Equal(t, gosnmp.Version2c, gs.Version)
|
|
|
|
assert.Equal(t, "foo", gs.Community)
|
2019-11-07 18:56:51 +00:00
|
|
|
assert.Equal(t, "udp", gs.Transport)
|
2016-08-22 15:37:53 +00:00
|
|
|
|
2017-10-25 22:28:55 +00:00
|
|
|
gsc, err = s.getConnection(1)
|
2016-08-22 15:37:53 +00:00
|
|
|
require.NoError(t, err)
|
|
|
|
gs = gsc.(gosnmpWrapper)
|
|
|
|
assert.Equal(t, "1.2.3.4", gs.Target)
|
|
|
|
assert.EqualValues(t, 161, gs.Port)
|
2019-11-07 18:56:51 +00:00
|
|
|
assert.Equal(t, "udp", gs.Transport)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGetSNMPConnectionTCP(t *testing.T) {
|
|
|
|
var wg sync.WaitGroup
|
|
|
|
wg.Add(1)
|
|
|
|
go stubTCPServer(&wg)
|
|
|
|
wg.Wait()
|
|
|
|
|
|
|
|
s := &Snmp{
|
|
|
|
Agents: []string{"tcp://127.0.0.1:56789"},
|
|
|
|
}
|
|
|
|
err := s.init()
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
wg.Add(1)
|
|
|
|
gsc, err := s.getConnection(0)
|
|
|
|
require.NoError(t, err)
|
|
|
|
gs := gsc.(gosnmpWrapper)
|
|
|
|
assert.Equal(t, "127.0.0.1", gs.Target)
|
|
|
|
assert.EqualValues(t, 56789, gs.Port)
|
|
|
|
assert.Equal(t, "tcp", gs.Transport)
|
|
|
|
wg.Wait()
|
|
|
|
}
|
|
|
|
|
|
|
|
func stubTCPServer(wg *sync.WaitGroup) {
|
|
|
|
defer wg.Done()
|
|
|
|
tcpAddr, _ := net.ResolveTCPAddr("tcp", "127.0.0.1:56789")
|
|
|
|
tcpServer, _ := net.ListenTCP("tcp", tcpAddr)
|
|
|
|
defer tcpServer.Close()
|
|
|
|
wg.Done()
|
|
|
|
conn, _ := tcpServer.AcceptTCP()
|
|
|
|
defer conn.Close()
|
2016-08-22 15:37:53 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
func TestGetSNMPConnection_v3(t *testing.T) {
|
|
|
|
s := &Snmp{
|
2017-10-25 22:28:55 +00:00
|
|
|
Agents: []string{"1.2.3.4"},
|
2016-08-22 15:37:53 +00:00
|
|
|
Version: 3,
|
|
|
|
MaxRepetitions: 20,
|
|
|
|
ContextName: "mycontext",
|
|
|
|
SecLevel: "authPriv",
|
|
|
|
SecName: "myuser",
|
|
|
|
AuthProtocol: "md5",
|
|
|
|
AuthPassword: "password123",
|
|
|
|
PrivProtocol: "des",
|
|
|
|
PrivPassword: "321drowssap",
|
|
|
|
EngineID: "myengineid",
|
|
|
|
EngineBoots: 1,
|
|
|
|
EngineTime: 2,
|
|
|
|
}
|
2017-10-25 22:28:55 +00:00
|
|
|
err := s.init()
|
|
|
|
require.NoError(t, err)
|
2016-08-22 15:37:53 +00:00
|
|
|
|
2017-10-25 22:28:55 +00:00
|
|
|
gsc, err := s.getConnection(0)
|
2016-08-22 15:37:53 +00:00
|
|
|
require.NoError(t, err)
|
|
|
|
gs := gsc.(gosnmpWrapper)
|
|
|
|
assert.Equal(t, gs.Version, gosnmp.Version3)
|
|
|
|
sp := gs.SecurityParameters.(*gosnmp.UsmSecurityParameters)
|
|
|
|
assert.Equal(t, "1.2.3.4", gsc.Host())
|
2016-09-18 00:10:46 +00:00
|
|
|
assert.EqualValues(t, 20, gs.MaxRepetitions)
|
2016-08-22 15:37:53 +00:00
|
|
|
assert.Equal(t, "mycontext", gs.ContextName)
|
|
|
|
assert.Equal(t, gosnmp.AuthPriv, gs.MsgFlags&gosnmp.AuthPriv)
|
|
|
|
assert.Equal(t, "myuser", sp.UserName)
|
|
|
|
assert.Equal(t, gosnmp.MD5, sp.AuthenticationProtocol)
|
|
|
|
assert.Equal(t, "password123", sp.AuthenticationPassphrase)
|
|
|
|
assert.Equal(t, gosnmp.DES, sp.PrivacyProtocol)
|
|
|
|
assert.Equal(t, "321drowssap", sp.PrivacyPassphrase)
|
|
|
|
assert.Equal(t, "myengineid", sp.AuthoritativeEngineID)
|
|
|
|
assert.EqualValues(t, 1, sp.AuthoritativeEngineBoots)
|
|
|
|
assert.EqualValues(t, 2, sp.AuthoritativeEngineTime)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGetSNMPConnection_caching(t *testing.T) {
|
2017-10-25 22:28:55 +00:00
|
|
|
s := &Snmp{
|
|
|
|
Agents: []string{"1.2.3.4", "1.2.3.5", "1.2.3.5"},
|
|
|
|
}
|
|
|
|
err := s.init()
|
|
|
|
require.NoError(t, err)
|
|
|
|
gs1, err := s.getConnection(0)
|
|
|
|
require.NoError(t, err)
|
|
|
|
gs2, err := s.getConnection(0)
|
2016-08-22 15:37:53 +00:00
|
|
|
require.NoError(t, err)
|
2017-10-25 22:28:55 +00:00
|
|
|
gs3, err := s.getConnection(1)
|
2016-08-22 15:37:53 +00:00
|
|
|
require.NoError(t, err)
|
2017-10-25 22:28:55 +00:00
|
|
|
gs4, err := s.getConnection(2)
|
2016-08-22 15:37:53 +00:00
|
|
|
require.NoError(t, err)
|
|
|
|
assert.True(t, gs1 == gs2)
|
|
|
|
assert.False(t, gs2 == gs3)
|
2017-10-25 22:28:55 +00:00
|
|
|
assert.False(t, gs3 == gs4)
|
2016-08-22 15:37:53 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
func TestGosnmpWrapper_walk_retry(t *testing.T) {
|
2018-02-01 23:05:39 +00:00
|
|
|
if testing.Short() {
|
|
|
|
t.Skip("Skipping test due to random failures.")
|
|
|
|
}
|
2016-08-22 15:37:53 +00:00
|
|
|
srvr, err := net.ListenUDP("udp4", &net.UDPAddr{})
|
|
|
|
defer srvr.Close()
|
|
|
|
require.NoError(t, err)
|
|
|
|
reqCount := 0
|
|
|
|
// Set up a WaitGroup to wait for the server goroutine to exit and protect
|
|
|
|
// reqCount.
|
|
|
|
// Even though simultaneous access is impossible because the server will be
|
|
|
|
// blocked on ReadFrom, without this the race detector gets unhappy.
|
|
|
|
wg := sync.WaitGroup{}
|
|
|
|
wg.Add(1)
|
|
|
|
go func() {
|
|
|
|
defer wg.Done()
|
|
|
|
buf := make([]byte, 256)
|
|
|
|
for {
|
|
|
|
_, addr, err := srvr.ReadFrom(buf)
|
|
|
|
if err != nil {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
reqCount++
|
|
|
|
|
|
|
|
srvr.WriteTo([]byte{'X'}, addr) // will cause decoding error
|
|
|
|
}
|
|
|
|
}()
|
|
|
|
|
|
|
|
gs := &gosnmp.GoSNMP{
|
|
|
|
Target: srvr.LocalAddr().(*net.UDPAddr).IP.String(),
|
|
|
|
Port: uint16(srvr.LocalAddr().(*net.UDPAddr).Port),
|
|
|
|
Version: gosnmp.Version2c,
|
|
|
|
Community: "public",
|
|
|
|
Timeout: time.Millisecond * 10,
|
|
|
|
Retries: 1,
|
|
|
|
}
|
|
|
|
err = gs.Connect()
|
|
|
|
require.NoError(t, err)
|
|
|
|
conn := gs.Conn
|
|
|
|
|
|
|
|
gsw := gosnmpWrapper{gs}
|
|
|
|
err = gsw.Walk(".1.0.0", func(_ gosnmp.SnmpPDU) error { return nil })
|
|
|
|
srvr.Close()
|
|
|
|
wg.Wait()
|
|
|
|
assert.Error(t, err)
|
|
|
|
assert.False(t, gs.Conn == conn)
|
|
|
|
assert.Equal(t, (gs.Retries+1)*2, reqCount)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGosnmpWrapper_get_retry(t *testing.T) {
|
2018-02-01 23:05:39 +00:00
|
|
|
// TODO: Fix this test
|
|
|
|
t.Skip("Test failing too often, skip for now and revisit later.")
|
2016-08-22 15:37:53 +00:00
|
|
|
srvr, err := net.ListenUDP("udp4", &net.UDPAddr{})
|
|
|
|
defer srvr.Close()
|
|
|
|
require.NoError(t, err)
|
|
|
|
reqCount := 0
|
|
|
|
// Set up a WaitGroup to wait for the server goroutine to exit and protect
|
|
|
|
// reqCount.
|
|
|
|
// Even though simultaneous access is impossible because the server will be
|
|
|
|
// blocked on ReadFrom, without this the race detector gets unhappy.
|
|
|
|
wg := sync.WaitGroup{}
|
|
|
|
wg.Add(1)
|
|
|
|
go func() {
|
|
|
|
defer wg.Done()
|
|
|
|
buf := make([]byte, 256)
|
|
|
|
for {
|
|
|
|
_, addr, err := srvr.ReadFrom(buf)
|
|
|
|
if err != nil {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
reqCount++
|
|
|
|
|
|
|
|
srvr.WriteTo([]byte{'X'}, addr) // will cause decoding error
|
|
|
|
}
|
|
|
|
}()
|
|
|
|
|
|
|
|
gs := &gosnmp.GoSNMP{
|
|
|
|
Target: srvr.LocalAddr().(*net.UDPAddr).IP.String(),
|
|
|
|
Port: uint16(srvr.LocalAddr().(*net.UDPAddr).Port),
|
|
|
|
Version: gosnmp.Version2c,
|
|
|
|
Community: "public",
|
|
|
|
Timeout: time.Millisecond * 10,
|
|
|
|
Retries: 1,
|
|
|
|
}
|
|
|
|
err = gs.Connect()
|
|
|
|
require.NoError(t, err)
|
|
|
|
conn := gs.Conn
|
|
|
|
|
|
|
|
gsw := gosnmpWrapper{gs}
|
|
|
|
_, err = gsw.Get([]string{".1.0.0"})
|
|
|
|
srvr.Close()
|
|
|
|
wg.Wait()
|
|
|
|
assert.Error(t, err)
|
|
|
|
assert.False(t, gs.Conn == conn)
|
|
|
|
assert.Equal(t, (gs.Retries+1)*2, reqCount)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestTableBuild_walk(t *testing.T) {
|
|
|
|
tbl := Table{
|
2017-03-24 19:06:52 +00:00
|
|
|
Name: "mytable",
|
|
|
|
IndexAsTag: true,
|
2016-08-22 15:37:53 +00:00
|
|
|
Fields: []Field{
|
|
|
|
{
|
|
|
|
Name: "myfield1",
|
|
|
|
Oid: ".1.0.0.0.1.1",
|
|
|
|
IsTag: true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
Name: "myfield2",
|
|
|
|
Oid: ".1.0.0.0.1.2",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
Name: "myfield3",
|
|
|
|
Oid: ".1.0.0.0.1.3",
|
|
|
|
Conversion: "float",
|
|
|
|
},
|
2016-09-18 03:08:00 +00:00
|
|
|
{
|
|
|
|
Name: "myfield4",
|
|
|
|
Oid: ".1.0.0.2.1.5",
|
|
|
|
OidIndexSuffix: ".9.9",
|
|
|
|
},
|
2018-04-18 00:34:39 +00:00
|
|
|
{
|
|
|
|
Name: "myfield5",
|
|
|
|
Oid: ".1.0.0.2.1.5",
|
|
|
|
OidIndexLength: 1,
|
|
|
|
},
|
2016-08-22 15:37:53 +00:00
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
tb, err := tbl.Build(tsc, true)
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
assert.Equal(t, tb.Name, "mytable")
|
|
|
|
rtr1 := RTableRow{
|
2017-03-24 19:06:52 +00:00
|
|
|
Tags: map[string]string{
|
|
|
|
"myfield1": "foo",
|
|
|
|
"index": "0",
|
|
|
|
},
|
2016-09-18 03:08:00 +00:00
|
|
|
Fields: map[string]interface{}{
|
|
|
|
"myfield2": 1,
|
|
|
|
"myfield3": float64(0.123),
|
|
|
|
"myfield4": 11,
|
2018-04-18 00:34:39 +00:00
|
|
|
"myfield5": 11,
|
2016-09-18 03:08:00 +00:00
|
|
|
},
|
2016-08-22 15:37:53 +00:00
|
|
|
}
|
|
|
|
rtr2 := RTableRow{
|
2017-03-24 19:06:52 +00:00
|
|
|
Tags: map[string]string{
|
|
|
|
"myfield1": "bar",
|
|
|
|
"index": "1",
|
|
|
|
},
|
2016-09-18 03:08:00 +00:00
|
|
|
Fields: map[string]interface{}{
|
|
|
|
"myfield2": 2,
|
|
|
|
"myfield3": float64(0.456),
|
|
|
|
"myfield4": 22,
|
2018-04-18 00:34:39 +00:00
|
|
|
"myfield5": 22,
|
2016-09-18 03:08:00 +00:00
|
|
|
},
|
2016-08-22 15:37:53 +00:00
|
|
|
}
|
2017-01-24 22:57:43 +00:00
|
|
|
rtr3 := RTableRow{
|
2017-03-24 19:06:52 +00:00
|
|
|
Tags: map[string]string{
|
|
|
|
"index": "2",
|
|
|
|
},
|
2017-01-24 22:57:43 +00:00
|
|
|
Fields: map[string]interface{}{
|
|
|
|
"myfield2": 0,
|
|
|
|
"myfield3": float64(0.0),
|
|
|
|
},
|
|
|
|
}
|
|
|
|
rtr4 := RTableRow{
|
2017-03-24 19:06:52 +00:00
|
|
|
Tags: map[string]string{
|
|
|
|
"index": "3",
|
|
|
|
},
|
2017-01-24 22:57:43 +00:00
|
|
|
Fields: map[string]interface{}{
|
|
|
|
"myfield3": float64(9.999),
|
|
|
|
},
|
|
|
|
}
|
|
|
|
assert.Len(t, tb.Rows, 4)
|
2016-08-22 15:37:53 +00:00
|
|
|
assert.Contains(t, tb.Rows, rtr1)
|
|
|
|
assert.Contains(t, tb.Rows, rtr2)
|
2017-01-24 22:57:43 +00:00
|
|
|
assert.Contains(t, tb.Rows, rtr3)
|
|
|
|
assert.Contains(t, tb.Rows, rtr4)
|
2016-08-22 15:37:53 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
func TestTableBuild_noWalk(t *testing.T) {
|
|
|
|
tbl := Table{
|
|
|
|
Name: "mytable",
|
|
|
|
Fields: []Field{
|
|
|
|
{
|
|
|
|
Name: "myfield1",
|
|
|
|
Oid: ".1.0.0.1.1",
|
|
|
|
IsTag: true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
Name: "myfield2",
|
|
|
|
Oid: ".1.0.0.1.2",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
Name: "myfield3",
|
|
|
|
Oid: ".1.0.0.1.2",
|
|
|
|
IsTag: true,
|
|
|
|
},
|
2016-10-04 14:46:01 +00:00
|
|
|
{
|
|
|
|
Name: "empty",
|
|
|
|
Oid: ".1.0.0.0.1.1.2",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
Name: "noexist",
|
|
|
|
Oid: ".1.2.3.4.5",
|
|
|
|
},
|
2016-08-22 15:37:53 +00:00
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
tb, err := tbl.Build(tsc, false)
|
|
|
|
require.NoError(t, err)
|
|
|
|
|
|
|
|
rtr := RTableRow{
|
|
|
|
Tags: map[string]string{"myfield1": "baz", "myfield3": "234"},
|
|
|
|
Fields: map[string]interface{}{"myfield2": 234},
|
|
|
|
}
|
|
|
|
assert.Len(t, tb.Rows, 1)
|
|
|
|
assert.Contains(t, tb.Rows, rtr)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGather(t *testing.T) {
|
|
|
|
s := &Snmp{
|
|
|
|
Agents: []string{"TestGather"},
|
|
|
|
Name: "mytable",
|
|
|
|
Fields: []Field{
|
|
|
|
{
|
|
|
|
Name: "myfield1",
|
|
|
|
Oid: ".1.0.0.1.1",
|
|
|
|
IsTag: true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
Name: "myfield2",
|
|
|
|
Oid: ".1.0.0.1.2",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
Name: "myfield3",
|
|
|
|
Oid: "1.0.0.1.1",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
Tables: []Table{
|
|
|
|
{
|
|
|
|
Name: "myOtherTable",
|
|
|
|
InheritTags: []string{"myfield1"},
|
|
|
|
Fields: []Field{
|
|
|
|
{
|
|
|
|
Name: "myOtherField",
|
2018-05-30 02:03:37 +00:00
|
|
|
Oid: ".1.0.0.0.1.5",
|
2016-08-22 15:37:53 +00:00
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
|
2017-10-25 22:28:55 +00:00
|
|
|
connectionCache: []snmpConnection{
|
|
|
|
tsc,
|
2016-08-22 15:37:53 +00:00
|
|
|
},
|
2017-10-25 22:28:55 +00:00
|
|
|
initialized: true,
|
2016-08-22 15:37:53 +00:00
|
|
|
}
|
|
|
|
acc := &testutil.Accumulator{}
|
|
|
|
|
|
|
|
tstart := time.Now()
|
|
|
|
s.Gather(acc)
|
|
|
|
tstop := time.Now()
|
|
|
|
|
|
|
|
require.Len(t, acc.Metrics, 2)
|
|
|
|
|
|
|
|
m := acc.Metrics[0]
|
|
|
|
assert.Equal(t, "mytable", m.Measurement)
|
|
|
|
assert.Equal(t, "tsc", m.Tags["agent_host"])
|
|
|
|
assert.Equal(t, "baz", m.Tags["myfield1"])
|
|
|
|
assert.Len(t, m.Fields, 2)
|
|
|
|
assert.Equal(t, 234, m.Fields["myfield2"])
|
|
|
|
assert.Equal(t, "baz", m.Fields["myfield3"])
|
|
|
|
assert.True(t, tstart.Before(m.Time))
|
|
|
|
assert.True(t, tstop.After(m.Time))
|
|
|
|
|
|
|
|
m2 := acc.Metrics[1]
|
|
|
|
assert.Equal(t, "myOtherTable", m2.Measurement)
|
|
|
|
assert.Equal(t, "tsc", m2.Tags["agent_host"])
|
|
|
|
assert.Equal(t, "baz", m2.Tags["myfield1"])
|
|
|
|
assert.Len(t, m2.Fields, 1)
|
|
|
|
assert.Equal(t, 123456, m2.Fields["myOtherField"])
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestGather_host(t *testing.T) {
|
|
|
|
s := &Snmp{
|
|
|
|
Agents: []string{"TestGather"},
|
|
|
|
Name: "mytable",
|
|
|
|
Fields: []Field{
|
|
|
|
{
|
|
|
|
Name: "host",
|
|
|
|
Oid: ".1.0.0.1.1",
|
|
|
|
IsTag: true,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
Name: "myfield2",
|
|
|
|
Oid: ".1.0.0.1.2",
|
|
|
|
},
|
|
|
|
},
|
|
|
|
|
2017-10-25 22:28:55 +00:00
|
|
|
connectionCache: []snmpConnection{
|
|
|
|
tsc,
|
2016-08-22 15:37:53 +00:00
|
|
|
},
|
2017-10-25 22:28:55 +00:00
|
|
|
initialized: true,
|
2016-08-22 15:37:53 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
acc := &testutil.Accumulator{}
|
|
|
|
|
|
|
|
s.Gather(acc)
|
|
|
|
|
|
|
|
require.Len(t, acc.Metrics, 1)
|
|
|
|
m := acc.Metrics[0]
|
|
|
|
assert.Equal(t, "baz", m.Tags["host"])
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestFieldConvert(t *testing.T) {
|
|
|
|
testTable := []struct {
|
|
|
|
input interface{}
|
|
|
|
conv string
|
|
|
|
expected interface{}
|
|
|
|
}{
|
|
|
|
{[]byte("foo"), "", string("foo")},
|
|
|
|
{"0.123", "float", float64(0.123)},
|
|
|
|
{[]byte("0.123"), "float", float64(0.123)},
|
|
|
|
{float32(0.123), "float", float64(float32(0.123))},
|
|
|
|
{float64(0.123), "float", float64(0.123)},
|
|
|
|
{123, "float", float64(123)},
|
|
|
|
{123, "float(0)", float64(123)},
|
|
|
|
{123, "float(4)", float64(0.0123)},
|
|
|
|
{int8(123), "float(3)", float64(0.123)},
|
|
|
|
{int16(123), "float(3)", float64(0.123)},
|
|
|
|
{int32(123), "float(3)", float64(0.123)},
|
|
|
|
{int64(123), "float(3)", float64(0.123)},
|
|
|
|
{uint(123), "float(3)", float64(0.123)},
|
|
|
|
{uint8(123), "float(3)", float64(0.123)},
|
|
|
|
{uint16(123), "float(3)", float64(0.123)},
|
|
|
|
{uint32(123), "float(3)", float64(0.123)},
|
|
|
|
{uint64(123), "float(3)", float64(0.123)},
|
|
|
|
{"123", "int", int64(123)},
|
|
|
|
{[]byte("123"), "int", int64(123)},
|
|
|
|
{float32(12.3), "int", int64(12)},
|
|
|
|
{float64(12.3), "int", int64(12)},
|
|
|
|
{int(123), "int", int64(123)},
|
|
|
|
{int8(123), "int", int64(123)},
|
|
|
|
{int16(123), "int", int64(123)},
|
|
|
|
{int32(123), "int", int64(123)},
|
|
|
|
{int64(123), "int", int64(123)},
|
|
|
|
{uint(123), "int", int64(123)},
|
|
|
|
{uint8(123), "int", int64(123)},
|
|
|
|
{uint16(123), "int", int64(123)},
|
|
|
|
{uint32(123), "int", int64(123)},
|
|
|
|
{uint64(123), "int", int64(123)},
|
2016-09-18 01:12:07 +00:00
|
|
|
{[]byte("abcdef"), "hwaddr", "61:62:63:64:65:66"},
|
|
|
|
{"abcdef", "hwaddr", "61:62:63:64:65:66"},
|
|
|
|
{[]byte("abcd"), "ipaddr", "97.98.99.100"},
|
|
|
|
{"abcd", "ipaddr", "97.98.99.100"},
|
|
|
|
{[]byte("abcdefghijklmnop"), "ipaddr", "6162:6364:6566:6768:696a:6b6c:6d6e:6f70"},
|
2016-08-22 15:37:53 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
for _, tc := range testTable {
|
2016-09-18 01:12:07 +00:00
|
|
|
act, err := fieldConvert(tc.conv, tc.input)
|
|
|
|
if !assert.NoError(t, err, "input=%T(%v) conv=%s expected=%T(%v)", tc.input, tc.input, tc.conv, tc.expected, tc.expected) {
|
|
|
|
continue
|
|
|
|
}
|
2016-08-22 15:37:53 +00:00
|
|
|
assert.EqualValues(t, tc.expected, act, "input=%T(%v) conv=%s expected=%T(%v)", tc.input, tc.input, tc.conv, tc.expected, tc.expected)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-02 04:45:37 +00:00
|
|
|
func TestSnmpTranslateCache_miss(t *testing.T) {
|
|
|
|
snmpTranslateCaches = nil
|
|
|
|
oid := "IF-MIB::ifPhysAddress.1"
|
2019-11-25 19:56:21 +00:00
|
|
|
mibName, oidNum, oidText, conversion, err := SnmpTranslate(oid)
|
2016-12-02 04:45:37 +00:00
|
|
|
assert.Len(t, snmpTranslateCaches, 1)
|
|
|
|
stc := snmpTranslateCaches[oid]
|
|
|
|
require.NotNil(t, stc)
|
|
|
|
assert.Equal(t, mibName, stc.mibName)
|
|
|
|
assert.Equal(t, oidNum, stc.oidNum)
|
|
|
|
assert.Equal(t, oidText, stc.oidText)
|
|
|
|
assert.Equal(t, conversion, stc.conversion)
|
|
|
|
assert.Equal(t, err, stc.err)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestSnmpTranslateCache_hit(t *testing.T) {
|
|
|
|
snmpTranslateCaches = map[string]snmpTranslateCache{
|
2018-10-19 20:32:54 +00:00
|
|
|
"foo": {
|
2016-12-02 04:45:37 +00:00
|
|
|
mibName: "a",
|
|
|
|
oidNum: "b",
|
|
|
|
oidText: "c",
|
|
|
|
conversion: "d",
|
|
|
|
err: fmt.Errorf("e"),
|
|
|
|
},
|
|
|
|
}
|
2019-11-25 19:56:21 +00:00
|
|
|
mibName, oidNum, oidText, conversion, err := SnmpTranslate("foo")
|
2016-12-02 04:45:37 +00:00
|
|
|
assert.Equal(t, "a", mibName)
|
|
|
|
assert.Equal(t, "b", oidNum)
|
|
|
|
assert.Equal(t, "c", oidText)
|
|
|
|
assert.Equal(t, "d", conversion)
|
|
|
|
assert.Equal(t, fmt.Errorf("e"), err)
|
|
|
|
snmpTranslateCaches = nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestSnmpTableCache_miss(t *testing.T) {
|
|
|
|
snmpTableCaches = nil
|
|
|
|
oid := ".1.0.0.0"
|
|
|
|
mibName, oidNum, oidText, fields, err := snmpTable(oid)
|
|
|
|
assert.Len(t, snmpTableCaches, 1)
|
|
|
|
stc := snmpTableCaches[oid]
|
|
|
|
require.NotNil(t, stc)
|
|
|
|
assert.Equal(t, mibName, stc.mibName)
|
|
|
|
assert.Equal(t, oidNum, stc.oidNum)
|
|
|
|
assert.Equal(t, oidText, stc.oidText)
|
|
|
|
assert.Equal(t, fields, stc.fields)
|
|
|
|
assert.Equal(t, err, stc.err)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestSnmpTableCache_hit(t *testing.T) {
|
|
|
|
snmpTableCaches = map[string]snmpTableCache{
|
2018-10-19 20:32:54 +00:00
|
|
|
"foo": {
|
2016-12-02 04:45:37 +00:00
|
|
|
mibName: "a",
|
|
|
|
oidNum: "b",
|
|
|
|
oidText: "c",
|
|
|
|
fields: []Field{{Name: "d"}},
|
|
|
|
err: fmt.Errorf("e"),
|
|
|
|
},
|
|
|
|
}
|
|
|
|
mibName, oidNum, oidText, fields, err := snmpTable("foo")
|
|
|
|
assert.Equal(t, "a", mibName)
|
|
|
|
assert.Equal(t, "b", oidNum)
|
|
|
|
assert.Equal(t, "c", oidText)
|
|
|
|
assert.Equal(t, []Field{{Name: "d"}}, fields)
|
|
|
|
assert.Equal(t, fmt.Errorf("e"), err)
|
|
|
|
}
|
|
|
|
|
2016-08-22 15:37:53 +00:00
|
|
|
func TestError(t *testing.T) {
|
|
|
|
e := fmt.Errorf("nested error")
|
|
|
|
err := Errorf(e, "top error %d", 123)
|
|
|
|
require.Error(t, err)
|
|
|
|
|
|
|
|
ne, ok := err.(NestedError)
|
|
|
|
require.True(t, ok)
|
|
|
|
assert.Equal(t, e, ne.NestedErr)
|
|
|
|
|
|
|
|
assert.Contains(t, err.Error(), "top error 123")
|
|
|
|
assert.Contains(t, err.Error(), "nested error")
|
|
|
|
}
|