dom
/
telegraf
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix handling of uint64 in datadog output (#4091)

This commit is contained in:
Daniel Nelson 2018-05-01 18:56:39 -07:00 committed by GitHub
parent c03e8918a2
commit cff7ee8edf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
plugins/outputs/datadog/datadog.go
View File

@ -179,13 +179,9 @@ func verifyValue(v interface{}) bool {
func (p *Point) setValue(v interface{}) error {
switch d := v.(type) {
case int:
p[1] = float64(int(d))
case int32:
p[1] = float64(int32(d))
case int64:
p[1] = float64(int64(d))
case float32:
p[1] = float64(d)
case uint64:
p[1] = float64(d)
case float64:
p[1] = float64(d)
@ -195,7 +191,7 @@ func (p *Point) setValue(v interface{}) error {
p[1] = float64(1)
}
default:
return fmt.Errorf("undeterminable type")
return fmt.Errorf("undeterminable field type: %T", v)
}
return nil
}

24
plugins/outputs/datadog/datadog_test.go
View File

@ -168,6 +168,30 @@ func TestBuildPoint(t *testing.T) {
},
nil,
},
{
testutil.TestMetric(int64(0), "test int64"),
Point{
float64(time.Date(2009, time.November, 10, 23, 0, 0, 0, time.UTC).Unix()),
0.0,
},
nil,
},
{
testutil.TestMetric(uint64(0), "test uint64"),
Point{
float64(time.Date(2009, time.November, 10, 23, 0, 0, 0, time.UTC).Unix()),
0.0,
},
nil,
},
{
testutil.TestMetric(true, "test bool"),
Point{
float64(time.Date(2009, time.November, 10, 23, 0, 0, 0, time.UTC).Unix()),
1.0,
},
nil,
},
}
for _, tt := range tagtests {
pt, err := buildMetrics(tt.ptIn)