Commit Graph

8 Commits

Author SHA1 Message Date
omgold 12831f43d4 Allow devices option to match against devlinks (#5817) 2019-05-15 12:21:55 -07:00
Soulou 205de66dd6
[diskio] Force type of stat.Rdev uint64 for mipsle compatibility
For most platforms, stat.Rdev is already a uint64 so this is without any effect
for linux,mipsle, unix.Stat_t.Rdev is a uint32, but the way to compute major and minor doesn't change, casting the uint32 has no impact either
2019-03-21 12:00:20 +01:00
Soulou 2118fbe78a
Use unix.Major/unix.Minor instead of custom implementation 2019-03-15 14:36:56 +01:00
Soulou 92b01ab4f9
Fix how major and minor identifiers of block devices are read.
The current implementation assure that the major and the minor are
coded on one byte. But they are not:

```
brw-rw----  1 root disk    252, 290 Feb 25 11:36 dm-290
```

290 as minor in this example is over 1 byte.

So after wondering why all my devices iops weren't correctly stored,
I found out that several points were added for some disks. For `dm-290`
it was overriding `252:34`, instead of getting udev stats for `252:290`.

The solution is here:
https://sites.uclouvain.be/SystInfo/usr/include/sys/sysmacros.h.html

The implementation is directly taken from this, fixing my bug.
2019-03-11 01:31:30 +01:00
Daniel Nelson 8526aa5c87
Update changelog 2018-12-13 11:51:53 -08:00
dbergmanskytap 6b5ddbbf66 Include DEVLINKS in available diskio udev properties (#5116) 2018-12-13 11:49:19 -08:00
Trevor Pounds ee056278f5 Enable gofmt code simplification (#4887) 2018-10-19 13:32:54 -07:00
Steve Domino 7b73b0db3a Moved system package inputs out to top level (#4406) 2018-07-11 16:43:49 -07:00