Commit Graph

38 Commits

Author SHA1 Message Date
Daniel Nelson 0882479cbf
Add command logging to snmp input at debug level () 2019-02-25 11:04:34 -08:00
wegel 06d5501d92 Add IPSIpAddress syntax to ipaddr conversion in snmp plugin () 2018-07-30 13:31:23 -06:00
Patrick Hemmer 5ae2b02f5d Fix snmp overriding of auto-configured table fields ()
Whenever the snmp plugin was configured with a table with automatic field
discovery, if one of those fields was explicitly overridden in the config and
the value of is_tag was changed, the field would be duplicated, once as a tag
& once as a field.

This change fixes the behavior so that if a field is explicitly configured,
automatic table field discovery doesn't touch it.
2018-05-29 19:03:37 -07:00
Matt 9ef902f4a1 Add snmp input option to strip non fixed length index suffixes () 2018-04-17 17:34:39 -07:00
Daniel Nelson d5bd426e0c
Fix snmp tools output parsing when they contain Windows eols () 2017-11-20 16:48:30 -08:00
Daniel Nelson a519abf13f Gather concurrently from snmp agents () 2017-10-25 15:28:55 -07:00
Patrick Hemmer 516dffa4c4 set default measurement name on snmp input () 2017-04-10 16:45:02 -07:00
Patrick Hemmer 995546e7c6 snmp: support table indexes as tags () 2017-03-24 12:06:52 -07:00
Jonas Hahnfeld c4d4185fb5 snmp: Allow lines with empty or missing tags ()
The changes in  resulted in lines being dropped if they had an empty
tag. Let's allow all lines that have empty or missing tags!
2017-01-24 14:57:43 -08:00
Patrick Hemmer a658e6c509 ensure proper context on snmp error messages () 2017-01-09 13:03:33 +00:00
Patrick Hemmer b58926dd26 snmp: use a shared global translation cache
Prevents the same data from being looked up multiple times. Also prevents multiple simultaneous lookups.

closes 
closes 
2016-12-12 13:32:42 +00:00
Patrick Hemmer 91143dda1a snmp: make snmptranslate not required () 2016-12-12 13:30:07 +00:00
Patrick Hemmer 80df3f7634 snmp: fix initialization of table fields in manual tables () 2016-10-12 11:00:39 +01:00
Patrick Hemmer 5a86a2ff26 snmp: return error on unknown conversion type () 2016-10-06 14:23:51 +01:00
Patrick Hemmer 7b05170145 update to latest gosnmp () 2016-10-05 08:40:56 +01:00
Patrick Hemmer b48ad4b737 fix snmp emitting empty fields
closes 
closes 
2016-10-04 16:25:16 +01:00
Patrick Hemmer 9feb639bbd fix translating snmp fields not in MIB () 2016-10-04 16:22:15 +01:00
Cameron Sparr e7e39df6a0 Default SNMP parameter changes
max-repetitions = 10 is the default of net-snmp utils according to
http://net-snmp.sourceforge.net/docs/man/snmpbulkwalk.html

retries = 3 is the default of gosnmp:
https://godoc.org/github.com/soniah/gosnmp#pkg-variables

Could deal with some parts of the performance issues reported
by 
2016-09-28 14:34:20 +01:00
Patrick Hemmer 055ef168ae add oid_index_suffix to snmp plugin 2016-09-27 11:30:25 +01:00
Patrick Hemmer 2778b7be30 add snmp conversions for MAC addresses & IPs 2016-09-27 11:30:25 +01:00
Patrick Hemmer 953db51b2c Adjust snmp translation to return conversion info.
Also consolidated the translation code to obtain all info with just 1 command execution.

Also split test command mocks out to their own file for cleanliness.
2016-09-27 11:30:25 +01:00
Patrick Hemmer 7fac74919c Alternate SNMP plugin ()
* Add a new and improved snmp plugin

* update gosnmp for duplicate packet fix

https://github.com/soniah/gosnmp/issues/68
https://github.com/soniah/gosnmp/pull/69
2016-08-22 16:37:53 +01:00
Cameron Sparr 4ce8dd5f9a Rename snmp plugin to snmp_legacy 2016-08-11 16:11:35 +01:00
Klaudiusz Staniek c6699c36d3 Add the OctetString OID value support ()
This update adds support for strings values. Not sure why this was missed.
2016-05-23 11:21:53 +01:00
Cameron Sparr 85dee02a3b snmp plugin: change host -> snmp_host
closes 
2016-05-10 14:18:00 -07:00
Cameron Sparr afdebbc3a2 Make OidInstanceMapping a field of the snmp host
fixes 
2016-05-10 10:15:01 -07:00
Larry Kim 46543d6323 Possible bug fix for oid_key collision
closes 
2016-04-19 17:00:04 -06:00
Thibault Cohen 75a9845d20 SNMP Fix
closes 
2016-04-18 11:19:16 -06:00
Cameron Sparr e436b2d720 Cleanup & standardize config file
changes:

- -sample-config will now comment out all but a few default plugins.
- config file parse errors will output path to bad conf file.
- cleanup 80-char line-length and some other style issues.
- default package conf file will now have all plugins, but commented
  out.

closes 
closes 
2016-04-01 10:59:53 -06:00
Thibault Cohen a95710ed0c SNMP plugin fixes
fixes 
2016-03-22 22:58:02 -06:00
Thibault Cohen 0752879fc8 SNMP fix concurrency issue
closes 
2016-03-10 12:04:29 +01:00
Matt Morrison 6139a69fa8 [SNMP Input] SNMPMap() loops forever if table has more than 32 entries
closes 
closes 
2016-03-07 12:18:55 +01:00
Thibault Cohen e5503c56ad Fix 2016-03-03 15:50:36 +00:00
Thibault Cohen ee7b225272 Add snmp table feature 2016-03-03 15:50:36 +00:00
Cameron Sparr 8d2e5f0bda Seems to be a toml parse bug around triple pounds 2016-02-18 14:36:03 -07:00
Cameron Sparr fc7fa4b6c5 Cleanup comments and indentation in config file 2016-02-09 11:01:50 -07:00
Cameron Sparr 9c0d14bb60 Create public models for telegraf metrics, accumlator, plugins
This will basically make the root directory a place for storing the
major telegraf interfaces, which will make telegraf's godoc looks quite
a bit nicer. And make it easier for contributors to lookup the few data
types that they actually care about.

closes 
2016-01-27 15:42:50 -07:00
Thibault Cohen e6d7e4e309 Add snmp input plugin
closes 
closes 
2016-01-25 12:35:27 -07:00